dart/lib/compiler/implementation/scanner/listener.dart - Issue 10870010: Evaluate compile-time constants of metadata.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/lib/compiler/implementation/scanner/listener.dart

Issue 10870010: Evaluate compile-time constants of metadata. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address review commens Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dart/lib/compiler/implementation/scanner/listener.dart

diff --git a/dart/lib/compiler/implementation/scanner/listener.dart b/dart/lib/compiler/implementation/scanner/listener.dart

index f606062ab159ea3b347085d68ca9d5ac7f70e681..ed75f5d1b500db58e87dc3d8c576186f07ce5d81 100644

--- a/dart/lib/compiler/implementation/scanner/listener.dart

+++ b/dart/lib/compiler/implementation/scanner/listener.dart

@@ -1646,7 +1646,13 @@ class PartialMetadataAnnotation extends MetadataAnnotation {

PartialMetadataAnnotation(this.beginToken);

- // TODO(ahe): Add more functionality as needed.

+ Node parseNode(DiagnosticListener listener) {

+ if (cachedNode !== null) return cachedNode;

+ cachedNode = parse(listener,

+ annotatedElement.getCompilationUnit(),

+ (p) => p.parseSend(beginToken.next));

+ return cachedNode;

+ }

}

Node parse(DiagnosticListener diagnosticListener,