Evaluate compile-time constants of metadata.

dart/lib/compiler/implementation/elements/elements.dart

Index: dart/lib/compiler/implementation/elements/elements.dart
diff --git a/dart/lib/compiler/implementation/elements/elements.dart b/dart/lib/compiler/implementation/elements/elements.dart
index 2cfa90d06652a110c01bd578db777c881f3c13b1..ae26a43cd157fbe6124c4fe1a7d04f87ac6f8016 100644
--- a/dart/lib/compiler/implementation/elements/elements.dart
+++ b/dart/lib/compiler/implementation/elements/elements.dart
@@ -1599,6 +1599,20 @@ class MetadataAnnotation {
    * In the mirror system, this would be an object mirror.
    */
   abstract Constant get value();
+  final Element enclosingElement;

[Johnni Winther, 2012/08/22 13:45:40]

enclosingElement is a bad name if it is always the compilation unit. I would
also expect the element to be the annotated element (which isn't enclosing
either).

[ahe, 2012/08/22 14:01:54]

It isn't supposed to always be a compilation unit. I just haven't written a test
where it isn't.

[ahe, 2012/08/22 17:23:02]

You convinced me offline that it should be annotatedElement instead. Works much
better, thank you.

+  int resolutionState;
+
+  MetadataAnnotation(this.enclosingElement,
+                     [this.resolutionState = ClassElement.STATE_NOT_STARTED]);

[Johnni Winther, 2012/08/22 13:45:40]

Why allow for another initial resolutionState?

[ahe, 2012/08/22 14:01:54]

I need that for PatchMetadataAnnotation.

+
+  abstract Node parseNode(DiagnosticListener listener);
+
+  MetadataAnnotation ensureResolved(Compiler compiler) {
+    if (resolutionState == ClassElement.STATE_NOT_STARTED) {
+      compiler.resolver.resolveMetadataAnnotation(this);
+    }
+    return this;
+  }
 
-  // TODO(ahe): Add more functionality as needed.
+  String toString() => 'MetadataAnnotation($value, $resolutionState)';
 }