Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1381)

Side by Side Diff: runtime/vm/flow_graph_builder.cc

Issue 10870004: Separate the checks from StoreInstanceField so that they can be eliminated. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/flow_graph_builder.h" 5 #include "vm/flow_graph_builder.h"
6 6
7 #include "vm/ast_printer.h" 7 #include "vm/ast_printer.h"
8 #include "vm/code_descriptors.h" 8 #include "vm/code_descriptors.h"
9 #include "vm/dart_entry.h" 9 #include "vm/dart_entry.h"
10 #include "vm/flags.h" 10 #include "vm/flags.h"
(...skipping 1955 matching lines...) Expand 10 before | Expand all | Expand 10 after
1966 ReturnComputation(store); 1966 ReturnComputation(store);
1967 } 1967 }
1968 1968
1969 1969
1970 void EffectGraphVisitor::VisitLoadInstanceFieldNode( 1970 void EffectGraphVisitor::VisitLoadInstanceFieldNode(
1971 LoadInstanceFieldNode* node) { 1971 LoadInstanceFieldNode* node) {
1972 ValueGraphVisitor for_instance(owner(), temp_index()); 1972 ValueGraphVisitor for_instance(owner(), temp_index());
1973 node->instance()->Visit(&for_instance); 1973 node->instance()->Visit(&for_instance);
1974 Append(for_instance); 1974 Append(for_instance);
1975 LoadInstanceFieldComp* load = new LoadInstanceFieldComp( 1975 LoadInstanceFieldComp* load = new LoadInstanceFieldComp(
1976 node->field(), for_instance.value(), NULL, 1976 node->field(), for_instance.value(), NULL); // Can not deoptimize.
1977 false); // Can not deoptimize.
1978 ReturnComputation(load); 1977 ReturnComputation(load);
1979 } 1978 }
1980 1979
1981 1980
1982 void EffectGraphVisitor::VisitStoreInstanceFieldNode( 1981 void EffectGraphVisitor::VisitStoreInstanceFieldNode(
1983 StoreInstanceFieldNode* node) { 1982 StoreInstanceFieldNode* node) {
1984 ValueGraphVisitor for_instance(owner(), temp_index()); 1983 ValueGraphVisitor for_instance(owner(), temp_index());
1985 node->instance()->Visit(&for_instance); 1984 node->instance()->Visit(&for_instance);
1986 Append(for_instance); 1985 Append(for_instance);
1987 ValueGraphVisitor for_value(owner(), for_instance.temp_index()); 1986 ValueGraphVisitor for_value(owner(), for_instance.temp_index());
(...skipping 426 matching lines...) Expand 10 before | Expand all | Expand 10 after
2414 intptr_t len = OS::SNPrint(NULL, 0, kFormat, function_name, reason) + 1; 2413 intptr_t len = OS::SNPrint(NULL, 0, kFormat, function_name, reason) + 1;
2415 char* chars = Isolate::Current()->current_zone()->Alloc<char>(len); 2414 char* chars = Isolate::Current()->current_zone()->Alloc<char>(len);
2416 OS::SNPrint(chars, len, kFormat, function_name, reason); 2415 OS::SNPrint(chars, len, kFormat, function_name, reason);
2417 const Error& error = Error::Handle( 2416 const Error& error = Error::Handle(
2418 LanguageError::New(String::Handle(String::New(chars)))); 2417 LanguageError::New(String::Handle(String::New(chars))));
2419 Isolate::Current()->long_jump_base()->Jump(1, error); 2418 Isolate::Current()->long_jump_base()->Jump(1, error);
2420 } 2419 }
2421 2420
2422 2421
2423 } // namespace dart 2422 } // namespace dart
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698