Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Unified Diff: chrome/browser/extensions/crx_installer.cc

Issue 10869084: Log additional information to try and track down a crash. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: dunno Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/crx_installer.cc
diff --git a/chrome/browser/extensions/crx_installer.cc b/chrome/browser/extensions/crx_installer.cc
index f323dde87ed1fbaab847d017c4de05f10b1cb7ca..d17820497c38819cf055bb9b4543362f7940d3dc 100644
--- a/chrome/browser/extensions/crx_installer.cc
+++ b/chrome/browser/extensions/crx_installer.cc
@@ -510,10 +510,13 @@ void CrxInstaller::CompleteInstall() {
extension_->creation_flags() | Extension::REQUIRE_KEY,
&error);
- LOG_ASSERT(error.empty()) << error << " " << extension_id << " "
- << download_url_.spec();
+ if (extension_) {
+ ReportSuccessFromFileThread();
+ } else {
+ LOG(ERROR) << error << " " << extension_id << " " << download_url_.spec();
+ ReportFailureFromFileThread(CrxInstallerError(UTF8ToUTF16(error)));
+ }
- ReportSuccessFromFileThread();
}
void CrxInstaller::ReportFailureFromFileThread(const CrxInstallerError& error) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698