Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issue 10869083: Fix a minor nit in the JSON schema compiler. (Closed)

Created:
8 years, 3 months ago by Lei Zhang
Modified:
8 years, 3 months ago
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Fix a minor nit in the JSON schema compiler. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153633

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/json_schema_compiler/cpp_type_generator.py View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
8 years, 3 months ago (2012-08-28 00:47:21 UTC) #1
not at google - send to devlin
lgtm https://chromiumcodereview.appspot.com/10869083/diff/1/tools/json_schema_compiler/cpp_type_generator.py File tools/json_schema_compiler/cpp_type_generator.py (right): https://chromiumcodereview.appspot.com/10869083/diff/1/tools/json_schema_compiler/cpp_type_generator.py#newcode252 tools/json_schema_compiler/cpp_type_generator.py:252: 'Maybe it needs a namespace prefix if it ...
8 years, 3 months ago (2012-08-28 01:32:34 UTC) #2
Lei Zhang
https://chromiumcodereview.appspot.com/10869083/diff/1/tools/json_schema_compiler/cpp_type_generator.py File tools/json_schema_compiler/cpp_type_generator.py (right): https://chromiumcodereview.appspot.com/10869083/diff/1/tools/json_schema_compiler/cpp_type_generator.py#newcode252 tools/json_schema_compiler/cpp_type_generator.py:252: 'Maybe it needs a namespace prefix if it comes ...
8 years, 3 months ago (2012-08-28 02:29:58 UTC) #3
Lei Zhang
8 years, 3 months ago (2012-08-28 02:29:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10869083/1002
8 years, 3 months ago (2012-08-28 02:30:51 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-08-28 06:16:53 UTC) #6
Change committed as 153633

Powered by Google App Engine
This is Rietveld 408576698