Deliver attach intent to packaged apps

chrome/browser/extensions/api/app_runtime/app_runtime_api.cc

Index: chrome/browser/extensions/api/app_runtime/app_runtime_api.cc
diff --git a/chrome/browser/extensions/api/app_runtime/app_runtime_api.cc b/chrome/browser/extensions/api/app_runtime/app_runtime_api.cc
index 2961e43234090a82c9d9e152da5765130da5b539..614dfe1e4de7d7bacbe1d403b98fff0e06cc8fee 100644
--- a/chrome/browser/extensions/api/app_runtime/app_runtime_api.cc
+++ b/chrome/browser/extensions/api/app_runtime/app_runtime_api.cc
@@ -87,6 +87,13 @@ void AppEventRouter::DispatchOnLaunchedEventWithWebIntent(
       // client code.
       args->Append(intent_data);
       break;
+    case webkit_glue::WebIntentData::FILESYSTEM:
+      intent_data = new DictionaryValue();
+      intent_data->SetString("format", "filesystem");
+      intent_data->SetString("fileSystemId", web_intent_data.filesystem_id);
+      intent_data->SetString("baseName", web_intent_data.root_name);

[benwells, 2012/08/27 08:25:51]

I don't understand why we need to send the base name here as well ... we don't
for the FileEntry case.

[thorogood, 2012/08/27 22:45:54]

We also send it for fileEntry? The baseName is the name that we're trying to
serve from within the isolated filesystem. (Notably, in both cases below, the
baseName and fileSystemId are stripped before sending to the client).

In the fileEntry case, it is the _only_ file that exists in the FS, and we want
to deliver it directly.

In the filesystem (this) case, it is the only _directory_ that exists in the FS,
and we want to create another fake FS that exists at that directory.

[thorogood, 2012/08/28 07:41:15]

I've discussed this with Ben, and confirmed that delivering filesystem intents
to hosted apps work in the same way as I'm building for packaged apps.

As discussed, the way an attached intent works is:
+ create virtual filesystem (empty)
+ add 'link' to the media device, as a single folder within the vfs
+ create a DOMFileSystem object (from app_runtime_custom_bindings.js) that
refers to the folder *within* the vfs
+ send that DOMFileSystem to the client

+      args->Append(intent_data);
+      break;
     default:
       NOTREACHED();
       break;