Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1108)

Unified Diff: content/common/gpu/media/omx_video_decode_accelerator.cc

Issue 10869065: Return immediately after NOTREACHED()'s to avoid logspam. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/gpu/media/omx_video_decode_accelerator.cc
diff --git a/content/common/gpu/media/omx_video_decode_accelerator.cc b/content/common/gpu/media/omx_video_decode_accelerator.cc
index 32fc6fb894ee141758547f326bb5d9b0357a9066..95c547f406f07eccdd244afafa52025ce0556f93 100644
--- a/content/common/gpu/media/omx_video_decode_accelerator.cc
+++ b/content/common/gpu/media/omx_video_decode_accelerator.cc
@@ -880,6 +880,7 @@ void OmxVideoDecodeAccelerator::DispatchStateReached(OMX_STATETYPE reached) {
return;
default:
NOTREACHED() << "Unexpected state in INITIALIZING: " << reached;
+ return;
}
case RESETTING:
switch (reached) {
@@ -891,6 +892,7 @@ void OmxVideoDecodeAccelerator::DispatchStateReached(OMX_STATETYPE reached) {
return;
default:
NOTREACHED() << "Unexpected state in RESETTING: " << reached;
+ return;
}
case DESTROYING:
switch (reached) {
@@ -910,6 +912,7 @@ void OmxVideoDecodeAccelerator::DispatchStateReached(OMX_STATETYPE reached) {
return;
default:
NOTREACHED() << "Unexpected state in DESTROYING: " << reached;
+ return;
}
case ERRORING:
switch (reached) {
@@ -918,6 +921,7 @@ void OmxVideoDecodeAccelerator::DispatchStateReached(OMX_STATETYPE reached) {
return;
default:
NOTREACHED() << "Unexpected state in ERRORING: " << reached;
+ return;
}
default:
NOTREACHED() << "Unexpected state in " << current_state_change_
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698