runtime/vm/scanner.cc - Issue 10869063: Add attributions so printf like functions can have their arguments checked.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/scanner.cc

Issue 10869063: Add attributions so printf like functions can have their arguments checked. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: rebased Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/scanner.cc

diff --git a/runtime/vm/scanner.cc b/runtime/vm/scanner.cc

index 1d6676c280132c1c9ffc6c660a2ab630f41091df..caca89c5e24765a7436014dceb84a1d3b7190317 100644

--- a/runtime/vm/scanner.cc

+++ b/runtime/vm/scanner.cc

@@ -944,7 +944,7 @@ RawString* Scanner::AllocatePrivateKey(const Library& library) {

}

char private_key[32];

OS::SNPrint(private_key, sizeof(private_key),

- "%c%"PRIxPTR, kPrivateKeySeparator, key_value);

+ "%c%#"Px"", kPrivateKeySeparator, key_value);

const String& result = String::Handle(String::New(private_key, Heap::kOld));

return result.raw();

}

« no previous file with comments | « runtime/vm/raw_object.cc ('k') | runtime/vm/scavenger.cc » ('j') | no next file with comments »