runtime/vm/heap_profiler.cc - Issue 10869063: Add attributions so printf like functions can have their arguments checked.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/heap_profiler.cc

Issue 10869063: Add attributions so printf like functions can have their arguments checked. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: rebased Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/heap_profiler.cc

diff --git a/runtime/vm/heap_profiler.cc b/runtime/vm/heap_profiler.cc

index 704309da83a7036922f423f89b616328fd4ae971..e5950675a761c9ce459d2f1cb662e288ef60bf4b 100644

--- a/runtime/vm/heap_profiler.cc

+++ b/runtime/vm/heap_profiler.cc

@@ -701,7 +701,7 @@ void HeapProfilerRootVisitor::VisitPointers(RawObject** first,

uword obj_addr = RawObject::ToAddr(raw_obj);

if (!Isolate::Current()->heap()->Contains(obj_addr) &&

!Dart::vm_isolate()->heap()->Contains(obj_addr)) {

- FATAL1("Invalid object pointer encountered 0x%lx\n", obj_addr);

+ FATAL1("Invalid object pointer encountered %#"Px"\n", obj_addr);

}

profiler_->WriteRoot(raw_obj);

« no previous file with comments | « runtime/vm/heap.cc ('k') | runtime/vm/il_printer.h » ('j') | no next file with comments »