Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: runtime/vm/exceptions.cc

Issue 10869063: Add attributions so printf like functions can have their arguments checked. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: rebased Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/disassembler_x64.cc ('k') | runtime/vm/flow_graph_allocator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/exceptions.cc
diff --git a/runtime/vm/exceptions.cc b/runtime/vm/exceptions.cc
index e42d463c49f19ec889b570b4ab83a4d11dc5c5bb..f063fcaa88409750c2935185c77a7cacf52c9e1c 100644
--- a/runtime/vm/exceptions.cc
+++ b/runtime/vm/exceptions.cc
@@ -307,7 +307,7 @@ void Exceptions::CreateAndThrowTypeError(intptr_t location,
}
intptr_t line, column;
script.GetTokenLocation(location, &line, &column);
- OS::Print("'%s': Failed type check: line %d pos %d: ",
+ OS::Print("'%s': Failed type check: line %"Pd" pos %"Pd": ",
String::Handle(script.url()).ToCString(), line, column);
if (!dst_name.IsNull() && (dst_name.Length() > 0)) {
OS::Print("type '%s' is not a subtype of type '%s' of '%s'.\n",
@@ -315,9 +315,7 @@ void Exceptions::CreateAndThrowTypeError(intptr_t location,
dst_type_name.ToCString(),
dst_name.ToCString());
} else {
- OS::Print("malformed type used.\n",
- String::Handle(script.url()).ToCString(),
- line, column);
+ OS::Print("malformed type used.\n");
}
}
// Throw TypeError instance.
« no previous file with comments | « runtime/vm/disassembler_x64.cc ('k') | runtime/vm/flow_graph_allocator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698