runtime/vm/debugger_api_impl_test.cc - Issue 10869063: Add attributions so printf like functions can have their arguments checked.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/debugger_api_impl_test.cc

Issue 10869063: Add attributions so printf like functions can have their arguments checked. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: rebased Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/debugger_api_impl_test.cc

diff --git a/runtime/vm/debugger_api_impl_test.cc b/runtime/vm/debugger_api_impl_test.cc

index 5ab46091740efb29d2aa3b7f9f9f37bfd3a7ad9c..944010e5c32c7315c228b416e21e3a722538f3dd 100644

--- a/runtime/vm/debugger_api_impl_test.cc

+++ b/runtime/vm/debugger_api_impl_test.cc

@@ -65,7 +65,7 @@ static char const* BreakpointInfo(Dart_StackTrace trace) {

res = Dart_ActivationFrameInfo(

frame, &func_name, &url, &line_number, &library_id);

EXPECT_VALID(res);

- OS::SNPrint(info_str, sizeof(info_str), "function %s (%s:%d)",

+ OS::SNPrint(info_str, sizeof(info_str), "function %s (%s:%"Pd")",

ToCString(func_name), ToCString(url), line_number);

return info_str;

}

« no previous file with comments | « runtime/vm/debugger_api_impl.cc ('k') | runtime/vm/deopt_instructions.cc » ('j') | no next file with comments »