Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Unified Diff: runtime/vm/class_finalizer.h

Issue 10869063: Add attributions so printf like functions can have their arguments checked. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: rebased Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/ast_printer.cc ('k') | runtime/vm/class_table.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/class_finalizer.h
diff --git a/runtime/vm/class_finalizer.h b/runtime/vm/class_finalizer.h
index 0abeb9c5ce21e69a6a4b1239efae5985215d6527..8c1267022da19b2d7b0e9f02f8cee57934abd6c2 100644
--- a/runtime/vm/class_finalizer.h
+++ b/runtime/vm/class_finalizer.h
@@ -53,7 +53,8 @@ class ClassFinalizer : public AllStatic {
const Class& cls,
const Type& type,
FinalizationKind finalization,
- const char* format, ...);
+ const char* format, ...)
+ PRINTF_ATTRIBUTE(5, 6);
// Return false if we still have classes pending to be finalized.
static bool AllClassesFinalized();
@@ -98,8 +99,8 @@ class ClassFinalizer : public AllStatic {
static void ReportError(const Error& error);
static void ReportError(const Script& script,
intptr_t token_index,
- const char* format, ...);
- static void ReportError(const char* format, ...);
+ const char* format, ...) PRINTF_ATTRIBUTE(3, 4);
+ static void ReportError(const char* format, ...) PRINTF_ATTRIBUTE(1, 2);
};
} // namespace dart
« no previous file with comments | « runtime/vm/ast_printer.cc ('k') | runtime/vm/class_table.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698