Add attributions so printf like functions can have their arguments checked.

runtime/vm/raw_object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/raw_object.h"
 
 #include "vm/class_table.h"
 #include "vm/freelist.h"
 #include "vm/isolate.h"
 #include "vm/object.h"
 #include "vm/visitor.h"
 
 
 namespace dart {
 
 void RawObject::Validate(Isolate* isolate) const {
   if (Object::null_class_ == reinterpret_cast<RawClass*>(kHeapObjectTag)) {
     // Validation relies on properly initialized class classes. Skip if the
     // VM is still being initialized.
     return;
   }
   // All Smi values are valid.
   if (!IsHeapObject()) {
     return;
   }
   // Validate that the tags_ field is sensible.
   uword tags = ptr()->tags_;
   intptr_t reserved = ReservedBits::decode(tags);
   if (reserved != 0) {
-    FATAL1("Invalid tags field encountered %#lx\n", tags);
+    FATAL1("Invalid tags field encountered %#"Px"\n", tags);
   }
   intptr_t class_id = ClassIdTag::decode(tags);
   if (!isolate->class_table()->IsValidIndex(class_id)) {
-    FATAL1("Invalid class id encountered %d\n", class_id);
+    FATAL1("Invalid class id encountered %"Pd"\n", class_id);
   }
   intptr_t size = SizeTag::decode(tags);
   if (size != 0 && size != SizeFromClass()) {
-    FATAL1("Inconsistent class size encountered %d\n", size);
+    FATAL1("Inconsistent class size encountered %"Pd"\n", size);
   }
 }
 
 
 intptr_t RawObject::SizeFromClass() const {
   Isolate* isolate = Isolate::Current();
   NoHandleScope no_handles(isolate);
 
   // Only reasonable to be called on heap objects.
   ASSERT(IsHeapObject());
@@ skipping 232 matching lines @@
       CLASS_LIST_NO_OBJECT(RAW_VISITPOINTERS)
 #undef RAW_VISITPOINTERS
       case kFreeListElement: {
         ASSERT(FreeBit::decode(ptr()->tags_));
         uword addr = RawObject::ToAddr(const_cast<RawObject*>(this));
         FreeListElement* element = reinterpret_cast<FreeListElement*>(addr);
         size = element->Size();
         break;
       }
       default:
-        OS::Print("Class Id: %d\n", class_id);
+        OS::Print("Class Id: %"Pd"\n", class_id);
         UNREACHABLE();
         break;
     }
   } else {
     RawClass* raw_class = visitor->isolate()->class_table()->At(class_id);
     if (Class::IsSignatureClass(raw_class)) {
       RawClosure* raw_obj = reinterpret_cast<RawClosure*>(this);
       size = RawClosure::VisitClosurePointers(raw_obj, visitor);
     } else {
       RawInstance* raw_obj = reinterpret_cast<RawInstance*>(this);
@@ skipping 676 matching lines @@
 
 intptr_t RawWeakProperty::VisitWeakPropertyPointers(
     RawWeakProperty* raw_obj, ObjectPointerVisitor* visitor) {
   // Make sure that we got here with the tagged pointer as this.
   ASSERT(raw_obj->IsHeapObject());
   visitor->VisitPointers(raw_obj->from(), raw_obj->to());
   return WeakProperty::InstanceSize();
 }
 
 }  // namespace dart