Add attributions so printf like functions can have their arguments checked.

runtime/vm/disassembler_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/disassembler.h"
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 #include "platform/utils.h"
 #include "vm/allocation.h"
@@ skipping 319 matching lines @@
   char* buffer_;  // Decode instructions into this buffer.
   intptr_t buffer_size_;  // The size of the buffer_.
   intptr_t buffer_pos_;  // Current character position in the buffer_.
 
   DISALLOW_COPY_AND_ASSIGN(X86Decoder);
 };
 
 
 void X86Decoder::PrintInt(int value) {
   char int_buffer[16];
-  OS::SNPrint(int_buffer, sizeof(int_buffer), "0x%x", value);
+  OS::SNPrint(int_buffer, sizeof(int_buffer), "%#x", value);
   Print(int_buffer);
 }
 
 
 // Append the int value (printed in hex) to the output buffer.
 void X86Decoder::PrintHex(int value) {
   char hex_buffer[16];
-  OS::SNPrint(hex_buffer, sizeof(hex_buffer), "0x%x", value);
+  OS::SNPrint(hex_buffer, sizeof(hex_buffer), "%#x", value);
   Print(hex_buffer);
 }
 
 
 // Append the str to the output buffer.
 void X86Decoder::Print(const char* str) {
   char cur = *str++;
   while (cur != '\0' && (buffer_pos_ < (buffer_size_ - 1))) {
     buffer_[buffer_pos_++] = cur;
     cur = *str++;
@@ skipping 52 matching lines @@
   intptr_t len = OS::SNPrint(NULL, 0, format, full_class_name) + 1;
   char* chars = Isolate::Current()->current_zone()->Alloc<char>(len);
   OS::SNPrint(chars, len, format, full_class_name);
   return chars;
 }
 
 
 void X86Decoder::PrintAddress(uword addr) {
   NoGCScope no_gc;
   char addr_buffer[32];
-  OS::SNPrint(addr_buffer, sizeof(addr_buffer), "%p", addr);
+  OS::SNPrint(addr_buffer, sizeof(addr_buffer), "%#"Px"", addr);
   Print(addr_buffer);
   // Try to print as heap object or stub name
   if (!Isolate::Current()->heap()->CodeContains(addr) &&
       Isolate::Current()->heap()->Contains(addr - kHeapObjectTag)) {
     Object& obj = Object::Handle(reinterpret_cast<RawObject*>(addr));
     if (obj.IsArray()) {
       const Array& arr = Array::CheckedHandle(obj.raw());
       intptr_t len = arr.Length();
       if (len > 5) len = 5;  // Print a max of 5 elements.
       Print("  Array[");
@@ skipping 1141 matching lines @@
       }
       case 0xF7:
         data += F7Instruction(data);
         break;
 
       case 0xC8:
         data += DecodeEnter(data);
         break;
 
       default:
-        OS::Print("Unknown case 0x%x\n", *data);
+        OS::Print("Unknown case %#x\n", *data);
         UNIMPLEMENTED();
     }
   }
 
   int instr_len = data - reinterpret_cast<uint8_t*>(pc);
   ASSERT(instr_len > 0);  // Ensure progress.
 
   return instr_len;
 }
 
@@ skipping 45 matching lines @@
                                   human_buffer,
                                   sizeof(human_buffer),
                                   pc);
     pc += instruction_length;
   }
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32