Add attributions so printf like functions can have their arguments checked.

runtime/vm/deopt_instructions.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/deopt_instructions.h"
 
 #include "vm/assembler_macros.h"
 #include "vm/intermediate_language.h"
 #include "vm/locations.h"
 #include "vm/parser.h"
@@ skipping 37 matching lines @@
  public:
   explicit DeoptStackSlotInstr(intptr_t from_index)
       : stack_slot_index_(from_index) {
     ASSERT(stack_slot_index_ >= 0);
   }
 
   virtual intptr_t from_index() const { return stack_slot_index_; }
   virtual DeoptInstr::Kind kind() const { return kCopyStackSlot; }
 
   virtual const char* ToCString() const {
-    intptr_t len = OS::SNPrint(NULL, 0, "s%d", stack_slot_index_);
+    const char* format = "s%"Pd"";
+    intptr_t len = OS::SNPrint(NULL, 0, format, stack_slot_index_);
     char* chars = Isolate::Current()->current_zone()->Alloc<char>(len + 1);
-    OS::SNPrint(chars, len + 1, "s%d", stack_slot_index_);
+    OS::SNPrint(chars, len + 1, format, stack_slot_index_);
     return chars;
   }
 
   void Execute(DeoptimizationContext* deopt_context, intptr_t to_index) {
     intptr_t from_index =
        deopt_context->from_frame_size() - stack_slot_index_ - 1;
     intptr_t* from_addr = deopt_context->GetFromFrameAddressAt(from_index);
     intptr_t* to_addr = deopt_context->GetToFrameAddressAt(to_index);
     *to_addr = *from_addr;
   }
 
  private:
   const intptr_t stack_slot_index_;  // First argument is 0, always >= 0.
 
   DISALLOW_COPY_AND_ASSIGN(DeoptStackSlotInstr);
 };
 
 
 class DeoptDoubleStackSlotInstr : public DeoptInstr {
  public:
   explicit DeoptDoubleStackSlotInstr(intptr_t from_index)
       : stack_slot_index_(from_index) {
     ASSERT(stack_slot_index_ >= 0);
   }
 
   virtual intptr_t from_index() const { return stack_slot_index_; }
   virtual DeoptInstr::Kind kind() const { return kCopyDoubleStackSlot; }
 
   virtual const char* ToCString() const {
-    intptr_t len = OS::SNPrint(NULL, 0, "ds%d", stack_slot_index_);
+    const char* format = "ds%"Pd"";
+    intptr_t len = OS::SNPrint(NULL, 0, format, stack_slot_index_);
     char* chars = Isolate::Current()->current_zone()->Alloc<char>(len + 1);
-    OS::SNPrint(chars, len + 1, "ds%d", stack_slot_index_);
+    OS::SNPrint(chars, len + 1, format, stack_slot_index_);
     return chars;
   }
 
   void Execute(DeoptimizationContext* deopt_context, intptr_t to_index) {
     intptr_t from_index =
        deopt_context->from_frame_size() - stack_slot_index_ - 1;
     double* from_addr = reinterpret_cast<double*>(
         deopt_context->GetFromFrameAddressAt(from_index));
     intptr_t* to_addr = deopt_context->GetToFrameAddressAt(to_index);
     *reinterpret_cast<RawSmi**>(to_addr) = Smi::New(0);
@@ skipping 15 matching lines @@
  public:
   explicit DeoptRetAddrAfterInstr(intptr_t object_table_index)
       : object_table_index_(object_table_index) {
     ASSERT(object_table_index >= 0);
   }
 
   virtual intptr_t from_index() const { return object_table_index_; }
   virtual DeoptInstr::Kind kind() const { return kSetRetAfterAddress; }
 
   virtual const char* ToCString() const {
-    intptr_t len = OS::SNPrint(NULL, 0, "ret aft oti:%d", object_table_index_);
+    const char* format = "ret aft oti:%"Pd"";
+    intptr_t len = OS::SNPrint(NULL, 0, format, object_table_index_);
     char* chars = Isolate::Current()->current_zone()->Alloc<char>(len + 1);
-    OS::SNPrint(chars, len + 1, "ret aft oti:%d", object_table_index_);
+    OS::SNPrint(chars, len + 1, format, object_table_index_);
     return chars;
   }
 
   void Execute(DeoptimizationContext* deopt_context, intptr_t to_index) {
     Function& function = Function::Handle(deopt_context->isolate());
     function ^= deopt_context->ObjectAt(object_table_index_);
     Smi& deopt_id_as_smi = Smi::Handle(deopt_context->isolate());
     deopt_id_as_smi ^= deopt_context->ObjectAt(object_table_index_ + 1);
     const Code& code =
         Code::Handle(deopt_context->isolate(), function.unoptimized_code());
@@ skipping 17 matching lines @@
  public:
   explicit DeoptRetAddrBeforeInstr(intptr_t object_table_index)
       : object_table_index_(object_table_index) {
     ASSERT(object_table_index >= 0);
   }
 
   virtual intptr_t from_index() const { return object_table_index_; }
   virtual DeoptInstr::Kind kind() const { return kSetRetBeforeAddress; }
 
   virtual const char* ToCString() const {
-    intptr_t len = OS::SNPrint(NULL, 0, "ret bef oti:%d", object_table_index_);
+    const char* format = "ret bef oti:%"Pd"";
+    intptr_t len = OS::SNPrint(NULL, 0, format, object_table_index_);
     char* chars = Isolate::Current()->current_zone()->Alloc<char>(len + 1);
-    OS::SNPrint(chars, len + 1, "ret bef oti:%d", object_table_index_);
+    OS::SNPrint(chars, len + 1, format, object_table_index_);
     return chars;
   }
 
   void Execute(DeoptimizationContext* deopt_context, intptr_t to_index) {
     Function& function = Function::Handle(deopt_context->isolate());
     function ^= deopt_context->ObjectAt(object_table_index_);
     Smi& deopt_id_as_smi = Smi::Handle(deopt_context->isolate());
     deopt_id_as_smi ^= deopt_context->ObjectAt(object_table_index_ + 1);
     const Code& code =
         Code::Handle(deopt_context->isolate(), function.unoptimized_code());
@@ skipping 15 matching lines @@
  public:
   explicit DeoptConstantInstr(intptr_t object_table_index)
       : object_table_index_(object_table_index) {
     ASSERT(object_table_index >= 0);
   }
 
   virtual intptr_t from_index() const { return object_table_index_; }
   virtual DeoptInstr::Kind kind() const { return kCopyConstant; }
 
   virtual const char* ToCString() const {
-    intptr_t len = OS::SNPrint(NULL, 0, "const oti:%d", object_table_index_);
+    const char* format = "const oti:%"Pd"";
+    intptr_t len = OS::SNPrint(NULL, 0, format, object_table_index_);
     char* chars = Isolate::Current()->current_zone()->Alloc<char>(len + 1);
-    OS::SNPrint(chars, len + 1, "const oti:%d", object_table_index_);
+    OS::SNPrint(chars, len + 1, format, object_table_index_);
     return chars;
   }
 
   void Execute(DeoptimizationContext* deopt_context, intptr_t to_index) {
     const Object& obj = Object::Handle(
         deopt_context->isolate(), deopt_context->ObjectAt(object_table_index_));
     RawObject** to_addr = reinterpret_cast<RawObject**>(
         deopt_context->GetToFrameAddressAt(to_index));
     *to_addr = obj.raw();
   }
@@ skipping 65 matching lines @@
  public:
   explicit DeoptPcMarkerInstr(intptr_t object_table_index)
       : object_table_index_(object_table_index) {
     ASSERT(object_table_index >= 0);
   }
 
   virtual intptr_t from_index() const { return object_table_index_; }
   virtual DeoptInstr::Kind kind() const { return kSetPcMarker; }
 
   virtual const char* ToCString() const {
-    intptr_t len = OS::SNPrint(NULL, 0, "pcmark oti:%d", object_table_index_);
+    const char* format = "pcmark oti:%"Pd"";
+    intptr_t len = OS::SNPrint(NULL, 0, format, object_table_index_);
     char* chars = Isolate::Current()->current_zone()->Alloc<char>(len + 1);
-    OS::SNPrint(chars, len + 1, "pcmark oti:%d", object_table_index_);
+    OS::SNPrint(chars, len + 1, format, object_table_index_);
     return chars;
   }
 
   void Execute(DeoptimizationContext* deopt_context, intptr_t to_index) {
     Function& function = Function::Handle(deopt_context->isolate());
     function ^= deopt_context->ObjectAt(object_table_index_);
     const Code& code =
         Code::Handle(deopt_context->isolate(), function.unoptimized_code());
     intptr_t pc_marker = code.EntryPoint() +
                          AssemblerMacros::kOffsetOfSavedPCfromEntrypoint;
@@ skipping 165 matching lines @@
   const intptr_t len = instructions_.length();
   const DeoptInfo& deopt_info = DeoptInfo::Handle(DeoptInfo::New(len));
   for (intptr_t i = 0; i < len; i++) {
     DeoptInstr* instr = instructions_[i];
     deopt_info.SetAt(i, instr->kind(), instr->from_index());
   }
   return deopt_info.raw();
 }
 
 }  // namespace dart