Add attributions so printf like functions can have their arguments checked.

runtime/vm/debugger.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/debugger.h"
 
 #include "vm/code_generator.h"
 #include "vm/code_patcher.h"
 #include "vm/compiler.h"
 #include "vm/dart_entry.h"
@@ skipping 853 matching lines @@
   }
   if (best_fit_index >= 0) {
     CodeBreakpoint* bpt = GetCodeBreakpoint(desc.PC(best_fit_index));
     // We should only ever have one code breakpoint at the same address.
     if (bpt != NULL) {
       return bpt;
     }
 
     bpt = new CodeBreakpoint(func, best_fit_index);
     if (FLAG_verbose_debug) {
-      OS::Print("Setting breakpoint in function '%s' (%s:%d) (PC %p)\n",
+      OS::Print("Setting breakpoint in function '%s' "
+                "(%s:%"Pd") (PC %#"Px")\n",
                 String::Handle(func.name()).ToCString(),
                 String::Handle(bpt->SourceUrl()).ToCString(),
                 bpt->LineNumber(),
                 bpt->pc());
     }
     RegisterCodeBreakpoint(bpt);
     return bpt;
   }
   return NULL;
 }
@@ skipping 31 matching lines @@
     if (bpt != NULL) {
       // A source breakpoint for this uncompiled location already
       // exists.
       return bpt;
     }
   }
   bpt = new SourceBreakpoint(nextId(), target_function, first_token_pos);
   RegisterSourceBreakpoint(bpt);
   if (FLAG_verbose_debug && !target_function.HasCode()) {
     OS::Print("Registering breakpoint for "
-              "uncompiled function '%s' at line %d\n",
+              "uncompiled function '%s' at line %"Pd"\n",
               target_function.ToFullyQualifiedCString(),
               bpt->LineNumber());
   }
 
   if (cbpt != NULL) {
     ASSERT(cbpt->src_bpt() == NULL);
     cbpt->set_src_bpt(bpt);
     SignalBpResolved(bpt);
   } else {
     if (FLAG_verbose_debug) {
-      OS::Print("Failed to set breakpoint at '%s' line %d\n",
+      OS::Print("Failed to set breakpoint at '%s' line %"Pd"\n",
                 String::Handle(bpt->SourceUrl()).ToCString(),
                 bpt->LineNumber());
     }
   }
   bpt->Enable();
   return bpt;
 }
 
 
 // Synchronize the enabled/disabled state of all code breakpoints
@@ skipping 40 matching lines @@
       OS::Print("Failed to find script with url '%s'\n",
                 script_url.ToCString());
     }
     return NULL;
   }
   intptr_t first_token_idx, last_token_idx;
   script.TokenRangeAtLine(line_number, &first_token_idx, &last_token_idx);
   if (first_token_idx < 0) {
     // Script does not contain the given line number.
     if (FLAG_verbose_debug) {
-      OS::Print("Script '%s' does not contain line number %d\n",
+      OS::Print("Script '%s' does not contain line number %"Pd"\n",
                 script_url.ToCString(), line_number);
     }
     return NULL;
   }
   const Function& func =
       Function::Handle(lib.LookupFunctionInScript(script, first_token_idx));
   if (func.IsNull()) {
     if (FLAG_verbose_debug) {
-      OS::Print("No executable code at line %d in '%s'\n",
+      OS::Print("No executable code at line %"Pd" in '%s'\n",
                 line_number, script_url.ToCString());
     }
     return NULL;
   }
   if (last_token_idx < 0) {
     // The token at first_token_index is past the requested source line.
     // Set the breakpoint at the closest position after that line.
     last_token_idx = func.end_token_pos();
   }
   return SetBreakpoint(func, first_token_idx, last_token_idx);
@@ skipping 214 matching lines @@
   }
 }
 
 
 static void DefaultBreakpointHandler(SourceBreakpoint* bpt,
                                      DebuggerStackTrace* stack) {
   String& var_name = String::Handle();
   Instance& value = Instance::Handle();
   for (intptr_t i = 0; i < stack->Length(); i++) {
     ActivationFrame* frame = stack->ActivationFrameAt(i);
-    OS::Print("   %d. %s\n",
+    OS::Print("   %"Pd". %s\n",
               i + 1, frame->ToCString());
     intptr_t num_locals = frame->NumLocalVariables();
     for (intptr_t i = 0; i < num_locals; i++) {
       intptr_t token_pos, end_pos;
       frame->VariableAt(i, &var_name, &token_pos, &end_pos, &value);
-      OS::Print("      var %s (pos %d) = %s\n",
+      OS::Print("      var %s (pos %"Pd") = %s\n",
                 var_name.ToCString(), token_pos, value.ToCString());
     }
   }
 }
 
 
 void Debugger::SetBreakpointHandler(BreakpointHandler* handler) {
   bp_handler_ = handler;
   if (bp_handler_ == NULL) {
     bp_handler_ = &DefaultBreakpointHandler;
@@ skipping 23 matching lines @@
   if (ignore_breakpoints_) {
     return;
   }
   DebuggerStackTrace* stack_trace = CollectStackTrace();
   ASSERT(stack_trace->Length() > 0);
   ActivationFrame* top_frame = stack_trace->ActivationFrameAt(0);
   ASSERT(top_frame != NULL);
   CodeBreakpoint* bpt = GetCodeBreakpoint(top_frame->pc());
   ASSERT(bpt != NULL);
   if (FLAG_verbose_debug) {
-    OS::Print(">>> hit %s breakpoint at %s:%d (Address %p)\n",
+    OS::Print(">>> hit %s breakpoint at %s:%"Pd" (Address %#"Px")\n",
               bpt->IsInternal() ? "internal" : "user",
               String::Handle(bpt->SourceUrl()).ToCString(),
               bpt->LineNumber(),
               top_frame->pc());
   }
 
   if (!bpt->IsInternal()) {
     // This is a user-defined breakpoint so we call the breakpoint
     // callback even if it is on the same line as the previous breakpoint.
     last_bpt_line_ = -1;
@@ skipping 262 matching lines @@
 }
 
 
 void Debugger::RegisterCodeBreakpoint(CodeBreakpoint* bpt) {
   ASSERT(bpt->next() == NULL);
   bpt->set_next(code_breakpoints_);
   code_breakpoints_ = bpt;
 }
 
 }  // namespace dart