Add attributions so printf like functions can have their arguments checked.

runtime/vm/ast_printer.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/ast_printer.h"
 
 #include "vm/handles.h"
 #include "vm/object.h"
 #include "vm/os.h"
 #include "vm/parser.h"
@@ skipping 12 matching lines @@
   OS::Print(")");
 }
 
 
 void AstPrinter::VisitSequenceNode(SequenceNode* node_sequence) {
   // TODO(regis): Make the output more readable by indenting the nested
   // sequences. This could be achieved using a AstPrinterContext similar to the
   // CodeGeneratorContext.
   ASSERT(node_sequence != NULL);
   for (int i = 0; i < node_sequence->length(); i++) {
-    OS::Print("scope 0x%x: ",
+    OS::Print("scope %p: ",
               node_sequence->scope());
     node_sequence->NodeAt(i)->Visit(this);
     OS::Print("\n");
   }
 }
 
 
 void AstPrinter::VisitCloneContextNode(CloneContextNode* node) {
   VisitGenericAstNode(node);
 }
 
 
 void AstPrinter::VisitArgumentListNode(ArgumentListNode* arguments) {
   VisitGenericAstNode(arguments);
 }
 
 
 void AstPrinter::VisitArgumentDefinitionTestNode(
     ArgumentDefinitionTestNode* node) {
-  OS::Print("(%s ?%s @%d)",
+  OS::Print("(%s ?%s @%"Pd")",
             node->Name(),
             node->formal_parameter_name().ToCString(),
             node->formal_parameter_index());
 }
 
 
 void AstPrinter::VisitReturnNode(ReturnNode* node) {
   VisitGenericAstNode(node);
 }
 
@@ skipping 173 matching lines @@
 void AstPrinter::VisitDoWhileNode(DoWhileNode* node) {
   OS::Print("(do ");
   node->body()->Visit(this);
   OS::Print(" while ");
   node->condition()->Visit(this);
   OS::Print(")");
 }
 
 
 void AstPrinter::VisitJumpNode(JumpNode* node) {
-  OS::Print("(%s %s in scope 0x%x)",
+  OS::Print("(%s %s in scope %p)",
             node->Name(),
             node->label()->name().ToCString(),
             node->label()->owner());
 }
 
 
 void AstPrinter::VisitInstanceCallNode(InstanceCallNode* node) {
   OS::Print("(%s '%s'(", node->Name(), node->function_name().ToCString());
   node->VisitChildren(this);
   OS::Print("))");
@@ skipping 140 matching lines @@
       OS::Print(" alias");
     }
     if (var->HasIndex()) {
       OS::Print(" @%d", var->index());
       if (var->is_captured()) {
         OS::Print(" ctx %d", var->owner()->context_level());
       }
     } else if (var->owner()->function_level() != 0) {
       OS::Print(" lev %d", var->owner()->function_level());
     }
-    OS::Print(" valid %d-%d)", var->token_pos(), scope->end_token_pos());
+    OS::Print(" valid %"Pd"-%"Pd")",
+              var->token_pos(),
+              scope->end_token_pos());
   }
   const LocalScope* child = scope->child();
   while (child != NULL) {
-    OS::Print("{scope 0x%x ", child);
+    OS::Print("{scope %p ", child);
     if (child->HasContextLevel()) {
       OS::Print("ctx %d numctxvar %d ",
                 child->context_level(),
                 child->num_context_variables());
     }
     OS::Print("llev %d ", child->loop_level());
     PrintLocalScope(child, 0);
     OS::Print("}");
     child = child->sibling();
   }
 }
 
 
 void AstPrinter::PrintFunctionScope(const ParsedFunction& parsed_function) {
   HANDLESCOPE(Isolate::Current());
   const Function& function = parsed_function.function();
   const Array& default_parameter_values =
       parsed_function.default_parameter_values();
   SequenceNode* node_sequence = parsed_function.node_sequence();
   ASSERT(node_sequence != NULL);
   const LocalScope* scope = node_sequence->scope();
   ASSERT(scope != NULL);
   const char* function_name = function.ToFullyQualifiedCString();
-  OS::Print("Scope for function '%s' {scope 0x%x ", function_name, scope);
+  OS::Print("Scope for function '%s' {scope %p ", function_name, scope);
   if (scope->HasContextLevel()) {
     OS::Print("ctx %d numctxvar %d ",
               scope->context_level(),
               scope->num_context_variables());
   }
   OS::Print("llev %d ", scope->loop_level());
   const int num_fixed_params = function.num_fixed_parameters();
   const int num_opt_params = function.num_optional_parameters();
   const int num_params = num_fixed_params + num_opt_params;
   // Parameters must be listed first and must all appear in the top scope.
@@ skipping 11 matching lines @@
       const Object& default_parameter_value = Object::Handle(
           default_parameter_values.At(pos - num_fixed_params));
       OS::Print(" =%s", default_parameter_value.ToCString());
     }
     if (param->HasIndex()) {
       OS::Print(" @%d", param->index());
       if (param->is_captured()) {
         OS::Print(" ctx %d", param->owner()->context_level());
       }
     }
-    OS::Print(" valid %d-%d)", param->token_pos(), scope->end_token_pos());
+    OS::Print(" valid %"Pd"-%"Pd")",
+              param->token_pos(),
+              scope->end_token_pos());
     pos++;
   }
   // Visit remaining non-parameter variables and children scopes.
   PrintLocalScope(scope, pos);
   OS::Print("}\n");
 }
 
 
 void AstPrinter::PrintFunctionNodes(const ParsedFunction& parsed_function) {
   HANDLESCOPE(Isolate::Current());
   SequenceNode* node_sequence = parsed_function.node_sequence();
   ASSERT(node_sequence != NULL);
   AstPrinter ast_printer;
   const char* function_name =
       parsed_function.function().ToFullyQualifiedCString();
   OS::Print("Ast for function '%s' {\n", function_name);
   node_sequence->Visit(&ast_printer);
   OS::Print("}\n");
 }
 
 }  // namespace dart