Add attributions so printf like functions can have their arguments checked.

runtime/platform/globals.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef PLATFORM_GLOBALS_H_
 #define PLATFORM_GLOBALS_H_
 
 // __STDC_FORMAT_MACROS has to be defined before including <inttypes.h> to
 // enable platform independent printf format specifiers.
 #ifndef __STDC_FORMAT_MACROS
@@ skipping 112 matching lines @@
 #define PRIdPTR DART_PRINTF_PTR_PREFIX "d"
 #endif
 
 #if !defined(PRIxPTR)
 #define PRIxPTR DART_PRINTF_PTR_PREFIX "x"
 #endif
 
 #endif  // defined(TARGET_OS_WINDOWS)
 
 
+// Short form printf format specifiers
+#define Pd PRIdPTR
+#define Pu PRIuPTR
+#define Px PRIxPTR
+#define Pd64 PRId64
+#define Pu64 PRIu64
+#define Px64 PRIx64
+
+
 // Suffixes for 64-bit integer literals.
 #ifdef _MSC_VER
 #define DART_INT64_C(x) x##I64
 #define DART_UINT64_C(x) x##UI64
 #else
 #define DART_INT64_C(x) x##LL
 #define DART_UINT64_C(x) x##ULL
 #endif
 
 
@@ skipping 209 matching lines @@
 // errors (type long int changed to int64_t and do/while split on
 // separate lines with body in {}s).
 # define TEMP_FAILURE_RETRY(expression)                                        \
     ({ int64_t __result;                                                       \
        do {                                                                    \
          __result = (int64_t) (expression);                                    \
        } while (__result == -1L && errno == EINTR);                            \
        __result; })
 #endif
 
+
+#if defined(TARGET_OS_LINUX) || defined(TARGET_OS_MACOS)
+//
+// Tell the compiler to do printf format string checking if the
+// compiler supports it; see the 'format' attribute in
+// <http://gcc.gnu.org/onlinedocs/gcc-4.3.0/gcc/Function-Attributes.html>.
+//
+// N.B.: As the GCC manual states, "[s]ince non-static C++ methods
+// have an implicit 'this' argument, the arguments of such methods
+// should be counted from two, not one."
+//
+#define PRINTF_ATTRIBUTE(string_index, first_to_check) \
+  __attribute__((__format__(__printf__, string_index, first_to_check)))
+#else
+#define PRINTF_ATTRIBUTE(string_index, first_to_check)
+#endif
+
 #endif  // PLATFORM_GLOBALS_H_