Add attributions so printf like functions can have their arguments checked.

runtime/bin/dbg_connection.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/dbg_connection.h"
 #include "bin/dartutils.h"
 #include "bin/socket.h"
 #include "bin/thread.h"
 #include "bin/utils.h"
 
@@ skipping 439 matching lines @@
   if (Dart_IsInteger(object)) {
     buf->Printf("\"kind\":\"integer\",");
   } else if (Dart_IsString(object)) {
     buf->Printf("\"kind\":\"string\",");
   } else if (Dart_IsBoolean(object)) {
     buf->Printf("\"kind\":\"boolean\",");
   } else if (Dart_IsList(object)) {
     intptr_t len = 0;
     Dart_Handle res = Dart_ListLength(object, &len);
     ASSERT_NOT_ERROR(res);
-    buf->Printf("\"kind\":\"list\",\"length\":%d,", len);
+    buf->Printf("\"kind\":\"list\",\"length\":%"Pd",", len);
   } else {
     buf->Printf("\"kind\":\"object\",");
   }
   FormatTextualValue(buf, object);
 }
 
 
 static void FormatValueObj(dart::TextBuffer* buf, Dart_Handle object) {
   buf->Printf("{");
   FormatValue(buf, object);
   buf->Printf("}");
 }
 
 
 static void FormatRemoteObj(dart::TextBuffer* buf, Dart_Handle object) {
   intptr_t obj_id = Dart_CacheObject(object);
   ASSERT(obj_id >= 0);
-  buf->Printf("{\"objectId\":%d,", obj_id);
+  buf->Printf("{\"objectId\":%"Pd",", obj_id);
   FormatValue(buf, object);
   buf->Printf("}");
 }
 
 
 static void FormatNamedValue(dart::TextBuffer* buf,
                              Dart_Handle object_name,
                              Dart_Handle object) {
   ASSERT(Dart_IsString(object_name));
   buf->Printf("{\"name\":\"%s\",", GetStringChars(object_name));
@@ skipping 29 matching lines @@
                                     intptr_t cls_id) {
   Dart_Handle name, static_fields;
   intptr_t super_id = -1;
   intptr_t library_id = -1;
   Dart_Handle res =
       Dart_GetClassInfo(cls_id, &name, &library_id, &super_id, &static_fields);
   RETURN_IF_ERROR(res);
   RETURN_IF_ERROR(name);
   buf->Printf("{\"name\":\"%s\",", GetStringChars(name));
   if (super_id > 0) {
-    buf->Printf("\"superclassId\":%d,", super_id);
+    buf->Printf("\"superclassId\":%"Pd",", super_id);
   }
-  buf->Printf("\"libraryId\":%d,", library_id);
+  buf->Printf("\"libraryId\":%"Pd",", library_id);
   RETURN_IF_ERROR(static_fields);
   buf->Printf("\"fields\":");
   FormatNamedValueList(buf, static_fields);
   buf->Printf("}");
   return NULL;
 }
 
 
 static const char* FormatLibraryProps(dart::TextBuffer* buf,
                                       intptr_t lib_id) {
@@ skipping 43 matching lines @@
 
 static const char* FormatObjProps(dart::TextBuffer* buf,
                                   Dart_Handle object) {
   intptr_t class_id;
   if (Dart_IsNull(object)) {
     buf->Printf("{\"classId\":-1,\"fields\":[]}");
     return NULL;
   }
   Dart_Handle res = Dart_GetObjClassId(object, &class_id);
   RETURN_IF_ERROR(res);
-  buf->Printf("{\"classId\": %d,", class_id);
+  buf->Printf("{\"classId\": %"Pd",", class_id);
   buf->Printf("\"kind\":\"object\",\"fields\":");
   Dart_Handle fields = Dart_GetInstanceFields(object);
   RETURN_IF_ERROR(fields);
   FormatNamedValueList(buf, fields);
   buf->Printf("}");
   return NULL;
 }
 
 
 static const char* FormatListSlice(dart::TextBuffer* buf,
                                    Dart_Handle list,
                                    intptr_t list_length,
                                    intptr_t index,
                                    intptr_t slice_length) {
   intptr_t end_index = index + slice_length;
   ASSERT(end_index <= list_length);
-  buf->Printf("{\"index\":%d,", index);
-  buf->Printf("\"length\":%d,", slice_length);
+  buf->Printf("{\"index\":%"Pd",", index);
+  buf->Printf("\"length\":%"Pd",", slice_length);
   buf->Printf("\"elements\":[");
   for (intptr_t i = index; i < end_index; i++) {
     Dart_Handle value = Dart_ListGetAt(list, i);
     if (i > index) {
       buf->Printf(",");
     }
     FormatValueObj(buf, value);
   }
   buf->Printf("]}");
   return NULL;
@@ skipping 12 matching lines @@
     Dart_Handle func_name;
     Dart_Handle script_url;
     intptr_t line_number = 0;
     intptr_t library_id = 0;
     res = Dart_ActivationFrameInfo(
         frame, &func_name, &script_url, &line_number, &library_id);
     ASSERT_NOT_ERROR(res);
     ASSERT(Dart_IsString(func_name));
     msg->Printf("%s{\"functionName\":", (i > 0) ? "," : "");
     FormatEncodedString(msg, func_name);
-    msg->Printf(",\"libraryId\": %d,", library_id);
+    msg->Printf(",\"libraryId\": %"Pd",", library_id);
 
     ASSERT(Dart_IsString(script_url));
     msg->Printf("\"location\": { \"url\":");
     FormatEncodedString(msg, script_url);
-    msg->Printf(",\"lineNumber\":%d},", line_number);
+    msg->Printf(",\"lineNumber\":%"Pd"},", line_number);
 
     Dart_Handle locals = Dart_GetLocalVariables(frame);
     ASSERT_NOT_ERROR(locals);
     msg->Printf("\"locals\":");
     FormatNamedValueList(msg, locals);
     msg->Printf("}");
   }
   msg->Printf("]");
 }
 
@@ skipping 23 matching lines @@
   Dart_Handle bp_id = Dart_SetBreakpoint(url, line_number);
   if (Dart_IsError(bp_id)) {
     SendError(msg_id, Dart_GetError(bp_id));
     return;
   }
   ASSERT(Dart_IsInteger(bp_id));
   uint64_t bp_id_value;
   Dart_Handle res = Dart_IntegerToUint64(bp_id, &bp_id_value);
   ASSERT_NOT_ERROR(res);
   dart::TextBuffer msg(64);
-  msg.Printf("{ \"id\": %d, \"result\": { \"breakpointId\": %d }}",
+  msg.Printf("{ \"id\": %d, \"result\": { \"breakpointId\": %"Pu64" }}",
              msg_id, bp_id_value);
   SendMsg(&msg);
 }
 
 
 void DebuggerConnectionHandler::HandlePauseOnExcCmd(const char* json_msg) {
   int msg_id = msgbuf_->MessageId();
   char* exc_chars = msgbuf_->GetStringParam("exceptions");
   Dart_ExceptionPauseInfo info = kNoPauseOnExceptions;
   if (strcmp(exc_chars, "none") == 0) {
@@ skipping 310 matching lines @@
   Dart_ExitScope();
 }
 
 
 void DebuggerConnectionHandler::BptResolvedHandler(intptr_t bp_id,
                                                    Dart_Handle url,
                                                    intptr_t line_number) {
   Dart_EnterScope();
   dart::TextBuffer msg(128);
   msg.Printf("{ \"event\": \"breakpointResolved\", \"params\": {");
-  msg.Printf("\"breakpointId\": %d, \"url\":", bp_id);
+  msg.Printf("\"breakpointId\": %"Pd", \"url\":", bp_id);
   FormatEncodedString(&msg, url);
-  msg.Printf(",\"line\": %d }}", line_number);
+  msg.Printf(",\"line\": %"Pd" }}", line_number);
   QueueMsg(&msg);
   Dart_ExitScope();
 }
 
 
 void DebuggerConnectionHandler::AcceptDbgConnection(int debugger_fd) {
   debugger_fd_ = debugger_fd;
   ASSERT(msgbuf_ == NULL);
   msgbuf_ = new MessageBuffer(debugger_fd_);
   {
@@ skipping 28 matching lines @@
   DebuggerConnectionImpl::StartHandler(port_number);
   Dart_SetBreakpointHandler(BreakpointHandler);
   Dart_SetBreakpointResolvedHandler(BptResolvedHandler);
   Dart_SetExceptionThrownHandler(ExceptionThrownHandler);
 }
 
 
 DebuggerConnectionHandler::~DebuggerConnectionHandler() {
   CloseDbgConnection();
 }