Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: chrome/browser/ui/intents/web_intent_picker_controller.cc

Issue 10869062: Don't block the tab when dispatching an intent until we're sure we're going to show a dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/intents/web_intent_picker_controller.cc
diff --git a/chrome/browser/ui/intents/web_intent_picker_controller.cc b/chrome/browser/ui/intents/web_intent_picker_controller.cc
index 64fdf2a93a62902570a86309b4ade165b9941808..c4bf0d2403ce831ca09a2746b2fc6a7f67917e73 100644
--- a/chrome/browser/ui/intents/web_intent_picker_controller.cc
+++ b/chrome/browser/ui/intents/web_intent_picker_controller.cc
@@ -194,10 +194,6 @@ void WebIntentPickerController::SetIntentsDispatcher(
void WebIntentPickerController::ShowDialog(const string16& action,
const string16& type) {
- // As soon as the dialog is requested, block all input events
- // on the original tab.
- tab_contents_->constrained_window_tab_helper()->BlockTabContent(true);
-
// Only show a picker once.
// TODO(gbillock): There's a hole potentially admitting multiple
// in-flight dispatches since we don't create the picker
@@ -251,6 +247,9 @@ void WebIntentPickerController::ShowDialog(const string16& action,
}
}
+ // As soon as the dialog is requested, block all input events
+ // on the original tab.
+ tab_contents_->constrained_window_tab_helper()->BlockTabContent(true);
SetDialogState(kPickerSetup);
pending_async_count_++;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698