Issue 10869062: Don't block the tab when dispatching an intent until we're sure we're going to show a dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10869062: Don't block the tab when dispatching an intent until we're sure we're going to show a dialog. (Closed)

Created:
8 years, 4 months ago by Mihai Parparita -not on Chrome

Modified:
8 years, 3 months ago

Reviewers:
Greg Billock

CC:
chromium-reviews, gbillock+watch_chromium.org, smckay+watch_chromium.org, groby+watch_chromium.org, groby-ooo-7-16

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Don't block the tab when dispatching an intent until we're sure we're going to show a dialog. BUG=144782 R=gbillock@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153523

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	chrome/browser/ui/intents/web_intent_picker_controller.cc	View		2 chunks	+3 lines, -4 lines	0 comments	Download

Total messages: 4 (0 generated)

Greg Billock

On 2012/08/25 00:57:42, Mihai Parparita wrote: lgtm thanks!

8 years, 3 months ago (2012-08-27 16:37:01 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihaip@chromium.org/10869062/1

8 years, 3 months ago (2012-08-27 17:12:44 UTC) #3

Change committed as 153523