Make IndexedDB layout browser tests save incorrect results to a file

Make IndexedDB layout browser tests save incorrect results to a file

Like it says in the bug, this won't help poring over a log on a bot, you'd still have to copy/paste and then unescape those results manually. But outputting to a file is so helpful when running a small amount of tests locally in a develop-compile-test cycle.

The expected and actual results of the test that inspired this are each >3k, of which about 100 bytes differed.

BUG=144786
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154896

[dgrogan, 2012-08-25 01:40:37]

John, could you take a look at this?  There's some context provided in the bug.

[jam, 2012-08-27 17:17:28]

-please make this output to a temp directory
-can this only be done if a special flag is passed? i.e.
--output-layout-test-differences
-seems like this should be done in layout_browsertest.cc, so that this can be
used with all tests which use this harness

[dgrogan, 2012-09-05 00:46:59]

Thanks for the review and good suggestions, I added them all. Could you take
another look?

[jam, 2012-09-05 01:33:37]

lgtm

https://codereview.chromium.org/10869061/diff/15001/content/test/layout_brows...
File content/test/layout_browsertest.cc (right):

https://codereview.chromium.org/10869061/diff/15001/content/test/layout_brows...
content/test/layout_browsertest.cc:223: << SaveResults(expected_text,
actual_text);
nit: I believe "<<" has to be at the start of the previous line per the style
guide

[dgrogan, 2012-09-05 02:03:30]

https://codereview.chromium.org/10869061/diff/15001/content/test/layout_brows...
File content/test/layout_browsertest.cc (right):

https://codereview.chromium.org/10869061/diff/15001/content/test/layout_brows...
content/test/layout_browsertest.cc:223: << SaveResults(expected_text,
actual_text);
On 2012/09/05 01:33:37, John Abd-El-Malek wrote:
> nit: I believe "<<" has to be at the start of the previous line per the style
> guide

Done.

I couldn't find this case in (or infer from) either style guide, but what you
suggest is definitely consistent with code in chromium and google3.

[commit-bot: I haz the power, 2012-09-05 02:04:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgrogan@chromium.org/10869061/17002

[commit-bot: I haz the power, 2012-09-05 04:24:53]

Change committed as 154896