Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 10869037: Implement status tray notifications in Windows 8 metro chrome using metro style notifications. We d… (Closed)

Created:
8 years, 4 months ago by ananta
Modified:
8 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Implement status tray notifications in Windows 8 metro chrome using metro style notifications. We don't support running native context menu's in these notifications. BUG=141159 R=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153303

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -2 lines) Patch
M chrome/browser/ui/views/status_icons/status_icon_win.h View 1 2 2 chunks +26 lines, -1 line 0 comments Download
M chrome/browser/ui/views/status_icons/status_icon_win.cc View 1 2 chunks +50 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/status_icons/status_tray_win.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
ananta
8 years, 4 months ago (2012-08-23 23:29:53 UTC) #1
sky
https://chromiumcodereview.appspot.com/10869037/diff/5001/chrome/browser/ui/views/status_icons/status_icon_win.cc File chrome/browser/ui/views/status_icons/status_icon_win.cc (right): https://chromiumcodereview.appspot.com/10869037/diff/5001/chrome/browser/ui/views/status_icons/status_icon_win.cc#newcode176 chrome/browser/ui/views/status_icons/status_icon_win.cc:176: DVLOG(1) << __FUNCTION__; Why the DVLOGs? https://chromiumcodereview.appspot.com/10869037/diff/5001/chrome/browser/ui/views/status_icons/status_icon_win.h File chrome/browser/ui/views/status_icons/status_icon_win.h ...
8 years, 4 months ago (2012-08-24 16:58:46 UTC) #2
ananta
https://chromiumcodereview.appspot.com/10869037/diff/5001/chrome/browser/ui/views/status_icons/status_icon_win.cc File chrome/browser/ui/views/status_icons/status_icon_win.cc (right): https://chromiumcodereview.appspot.com/10869037/diff/5001/chrome/browser/ui/views/status_icons/status_icon_win.cc#newcode176 chrome/browser/ui/views/status_icons/status_icon_win.cc:176: DVLOG(1) << __FUNCTION__; On 2012/08/24 16:58:47, sky wrote: > ...
8 years, 4 months ago (2012-08-24 18:03:41 UTC) #3
sky
8 years, 4 months ago (2012-08-24 19:03:35 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698