Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 10869017: Fix run_ppapi_ppp_input_event_browser_test and re-enable it. (Closed)

Created:
8 years, 4 months ago by yzshen1
Modified:
8 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix run_ppapi_ppp_input_event_browser_test and re-enable it. The test has hard-coded coordinates which doesn't match the current layout anymore. It "passed" because there was this bug http://code.google.com/p/chromium/issues/detail?id=140577, which has been fixed. BUG=143973 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153330

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M chrome/test/nacl_test_injection/buildbot_nacl_integration.py View 1 chunk +0 lines, -6 lines 0 comments Download
M ppapi/native_client/tests/ppapi_browser/ppp_input_event/ppapi_ppp_input_event.js View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
yzshen1
Hi, Nick. Would you please take a look? Thanks!
8 years, 4 months ago (2012-08-22 22:17:24 UTC) #1
Nick Bray (chromium)
non-commiter LGTM. Yeah, I need to apply for that bit.
8 years, 4 months ago (2012-08-22 23:07:15 UTC) #2
yzshen1
On 2012/08/22 23:07:15, Nick Bray (chromium) wrote: > non-commiter LGTM. > > Yeah, I need ...
8 years, 4 months ago (2012-08-22 23:09:48 UTC) #3
brettw
lgtm
8 years, 4 months ago (2012-08-24 18:12:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/10869017/1
8 years, 4 months ago (2012-08-24 18:13:21 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-24 22:44:33 UTC) #6
Change committed as 153330

Powered by Google App Engine
This is Rietveld 408576698