Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 10869002: Reland Integrate invalidation API into ChromeToMobileService. (Closed)

Created:
8 years, 4 months ago by msw
Modified:
8 years, 4 months ago
Reviewers:
sail, Elliot Glaysher, sky
CC:
chromium-reviews, tfarina, akalin, nyquist, dcheng, tim (not reviewing)
Visibility:
Public.

Description

Reland Integrate invalidation API into ChromeToMobileService. A continuation of http://codereview.chromium.org/10834203 r152609 reverted original r152609 for debug test crashes: http://build.chromium.org/p/chromium/builders/Mac%2010.7%20Tests%20%28dbg%29%284%29/builds/100/steps/browser_tests/logs/stdio Move dtor logic to a ProfileKeyedService::Shutdown OVERRIDE. This fixes the problem locally (we have no debug trybots?). Remaining description matches that of the original CL: ====================================================== Update chrome/browser/DEPS with new dependencies: (google/cacheinvalidation and sync/notifier) Observe Sync Notifier invalidation notifications: (depend on this service for mobile list updates) (refresh the device list on cloud print invalidation) Remove RequestMobileListUpdate, timestamp, & account info: (no longer needed with invalidation integration) (just set command state and icon visibility w/HasMobiles) Lazily init the access token, queue search/send operations: (only get an access token as needed, add |task_queue_|) Allow concurrent cloud print device search requests: (handle user-triggered updates while fetching the list) Misc cleanup (CloudPrintUrl handling, tests, etc.) TODO(followup): Additional logging, tests, invalidation ack. BUG=102709, 137086 TEST=Chrome To Mobile devices update with cloud print! Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152735

Patch Set 1 #

Patch Set 2 : Move ProfileSyncService unregistration code to Shutdown OVERRIDE. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -182 lines) Patch
M chrome/browser/DEPS View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/chrome_to_mobile_service.h View 1 9 chunks +32 lines, -20 lines 0 comments Download
M chrome/browser/chrome_to_mobile_service.cc View 1 14 chunks +122 lines, -120 lines 0 comments Download
M chrome/browser/chrome_to_mobile_service_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_to_mobile_service_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_to_mobile_service_unittest.cc View 2 chunks +13 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/chrome_to_mobile_bubble_controller.mm View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/chrome_to_mobile_bubble_controller_unittest.mm View 7 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/gtk/chrome_to_mobile_bubble_gtk.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/chrome_to_mobile_bubble_view.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
msw
Hey Elliot and Scott, please review the small diff, thanks! Patch Set 2 just tweaks ...
8 years, 4 months ago (2012-08-21 23:07:52 UTC) #1
Elliot Glaysher
On 2012/08/21 23:07:52, msw wrote: > Hey Elliot and Scott, please review the small diff, ...
8 years, 4 months ago (2012-08-21 23:17:33 UTC) #2
nyquist
lgtm
8 years, 4 months ago (2012-08-21 23:18:50 UTC) #3
msw
Sorry, I should have mentioned: erg: new ProfileKeyedService::Shutdown OVERRIDE sky: OWNERS (hopefully don't need more ...
8 years, 4 months ago (2012-08-21 23:19:30 UTC) #4
msw
Ah, +sail for chrome/browser/ui/cocoa/OWNERS
8 years, 4 months ago (2012-08-21 23:21:22 UTC) #5
Elliot Glaysher
that lg too.
8 years, 4 months ago (2012-08-21 23:21:33 UTC) #6
sail
cocoa/* LGTM
8 years, 4 months ago (2012-08-21 23:28:58 UTC) #7
sky
LGTM
8 years, 4 months ago (2012-08-21 23:43:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/10869002/2001
8 years, 4 months ago (2012-08-21 23:51:09 UTC) #9
commit-bot: I haz the power
8 years, 4 months ago (2012-08-22 04:16:13 UTC) #10
Change committed as 152735

Powered by Google App Engine
This is Rietveld 408576698