Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Unified Diff: chrome/browser/chromeos/cros/onc_network_parser_unittest.cc

Issue 10868113: Disable certificate patterns for device policy ONC files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review changes Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/cros/onc_network_parser.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/cros/onc_network_parser_unittest.cc
diff --git a/chrome/browser/chromeos/cros/onc_network_parser_unittest.cc b/chrome/browser/chromeos/cros/onc_network_parser_unittest.cc
index 664a1ab346316f54d43c40bbfca942001feebf6e..291f3794c7029151559c50f13ac51ad4a9e473fd 100644
--- a/chrome/browser/chromeos/cros/onc_network_parser_unittest.cc
+++ b/chrome/browser/chromeos/cros/onc_network_parser_unittest.cc
@@ -331,6 +331,32 @@ TEST_F(OncNetworkParserTest, TestLoadVPNCertificatePattern) {
vpn->client_cert_pattern().enrollment_uri_list()[1]);
}
+TEST_F(OncNetworkParserTest, TestNoCertificatePatternForDevicePolicy) {
+ std::string test_blob;
+ GetTestData("cert-pattern.onc", &test_blob);
+ OncNetworkParser parser(test_blob, "",
+ NetworkUIData::ONC_SOURCE_DEVICE_POLICY);
+
+ // Make sure we fail when parsing a certificate pattern from a device policy
+ // ONC file.
+ ASSERT_TRUE(parser.parse_error().empty());
+ EXPECT_EQ(1, parser.GetNetworkConfigsSize());
+ EXPECT_EQ(2, parser.GetCertificatesSize());
+ scoped_ptr<Network> network(parser.ParseNetwork(0, NULL));
+ ASSERT_TRUE(network.get());
+
+ EXPECT_EQ(chromeos::TYPE_WIFI, network->type());
+ WifiNetwork* wifi = static_cast<WifiNetwork*>(network.get());
+ EXPECT_EQ(chromeos::SECURITY_8021X, wifi->encryption());
+ EXPECT_EQ("WirelessNetwork", wifi->name());
+ EXPECT_FALSE(wifi->auto_connect());
+ EXPECT_EQ("", wifi->passphrase());
+ EXPECT_EQ(chromeos::EAP_METHOD_TLS, wifi->eap_method());
+ EXPECT_EQ(chromeos::CLIENT_CERT_TYPE_PATTERN, wifi->client_cert_type());
+ EXPECT_EQ("", wifi->client_cert_pattern().issuer().organization());
+ ASSERT_EQ(0ul, wifi->client_cert_pattern().enrollment_uri_list().size());
+}
+
TEST_F(OncNetworkParserTest, TestCreateNetworkWifiEAP1) {
std::string test_blob;
GetTestData("network-wifi-eap1.onc", &test_blob);
« no previous file with comments | « chrome/browser/chromeos/cros/onc_network_parser.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698