Disable certificate patterns for device policy ONC files

Disable certificate patterns for device policy ONC files 
so that an unmanaged user can't get to the place where a cert is
presented for them involuntarily.

BUG=chromium:135465
TEST=ran new unit test


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157806

[Greg Spencer (Chromium), 2012-08-27 21:22:51]

http://codereview.chromium.org/10868113/diff/1/chrome/browser/chromeos/cros/n...
File chrome/browser/chromeos/cros/network_library.cc (right):

http://codereview.chromium.org/10868113/diff/1/chrome/browser/chromeos/cros/n...
chrome/browser/chromeos/cros/network_library.cc:737: ui_data().onc_source() ==
NetworkUIData::ONC_SOURCE_DEVICE_POLICY) {
I added this check in addition to the ONC file loading failure so that already
imported policies will not do this either.

[Mattias Nissler (ping if slow), 2012-08-28 11:38:09]

http://codereview.chromium.org/10868113/diff/1/chrome/browser/chromeos/cros/o...
File chrome/browser/chromeos/cros/onc_network_parser.cc (right):

http://codereview.chromium.org/10868113/diff/1/chrome/browser/chromeos/cros/o...
chrome/browser/chromeos/cros/onc_network_parser.cc:1368: Network* network) {
Maybe it's better to put the check here instead of all case branches below?

http://codereview.chromium.org/10868113/diff/1/chrome/browser/chromeos/cros/o...
chrome/browser/chromeos/cros/onc_network_parser.cc:1385: parser->onc_source() ==
NetworkUIData::ONC_SOURCE_DEVICE_POLICY)
nit: Other code in this file seems to add curly braces for the
two-line-conditional, single-line-body case. Same below.

[satorux1, 2012-08-28 17:07:56]

I'm not very familiar with the networking code. maybe stevenjb?

[Greg Spencer (Chromium), 2012-09-17 18:25:44]

http://codereview.chromium.org/10868113/diff/1/chrome/browser/chromeos/cros/o...
File chrome/browser/chromeos/cros/onc_network_parser.cc (right):

http://codereview.chromium.org/10868113/diff/1/chrome/browser/chromeos/cros/o...
chrome/browser/chromeos/cros/onc_network_parser.cc:1368: Network* network) {
On 2012/08/28 11:38:09, Mattias Nissler wrote:
> Maybe it's better to put the check here instead of all case branches below?

Done.  For some reason I thought it would mess with parsing if we didn't parse
all the bits here.  It doesn't, so of course this makes sense.

http://codereview.chromium.org/10868113/diff/1/chrome/browser/chromeos/cros/o...
chrome/browser/chromeos/cros/onc_network_parser.cc:1385: parser->onc_source() ==
NetworkUIData::ONC_SOURCE_DEVICE_POLICY)
On 2012/08/28 11:38:09, Mattias Nissler wrote:
> nit: Other code in this file seems to add curly braces for the
> two-line-conditional, single-line-body case. Same below.

Done.

[Greg Spencer (Chromium), 2012-09-17 18:26:36]

Ping to steven too, now that he's back...

[stevenjb, 2012-09-18 21:47:13]

lgtm

[commit-bot: I haz the power, 2012-09-20 15:44:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gspencer@chromium.org/10868113/8001

[commit-bot: I haz the power, 2012-09-20 15:45:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gspencer@chromium.org/10868113/8001

[commit-bot: I haz the power, 2012-09-20 19:14:29]

Change committed as 157806