Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 10868111: Re-enable SSLUITest.TestBadHTTPSDownload and make it stop hanging by using a (Closed)

Created:
8 years, 3 months ago by pauljensen
Modified:
8 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Re-enable SSLUITest.TestBadHTTPSDownload and make it stop hanging by using a temporary download directory to avoid Chrome pending on user input of a new filename. BUG=144624 TEST=browser_tests --gtest_filter=SSLUITest.TestBadHTTPSDownload Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153589

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M chrome/browser/ssl/ssl_browser_tests.cc View 3 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pauljensen
Scott, Could you please review this fix and re-enabling of a test. I already [mistakenly] ...
8 years, 3 months ago (2012-08-27 19:02:38 UTC) #1
sky
LGTM
8 years, 3 months ago (2012-08-27 20:48:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pauljensen@chromium.org/10868111/1
8 years, 3 months ago (2012-08-27 21:53:51 UTC) #3
commit-bot: I haz the power
8 years, 3 months ago (2012-08-28 00:09:34 UTC) #4
Change committed as 153589

Powered by Google App Engine
This is Rietveld 408576698