Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1083)

Issue 10868110: Remove MediaDeviceMapService references from |DeviceAttachedIntentSource::OnMediaDetached| function. (Closed)

Created:
8 years, 3 months ago by kmadhusu
Modified:
8 years, 3 months ago
CC:
chromium-reviews, gbillock+watch_chromium.org, smckay+watch_chromium.org, groby+watch_chromium.org
Visibility:
Public.

Description

Remove MediaDeviceMapService references from |DeviceAttachedIntentSource::OnMediaDetached| function. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153573

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : Added TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -19 lines) Patch
M chrome/browser/intents/device_attached_intent_source.cc View 1 2 3 chunks +2 lines, -19 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kmadhusu
As a prep to test and commit webkit/fileapi/media/ code to support mtp devices, I am ...
8 years, 3 months ago (2012-08-27 17:37:39 UTC) #1
vandebo (ex-Chrome)
LGTM http://codereview.chromium.org/10868110/diff/2002/chrome/browser/intents/device_attached_intent_source.cc File chrome/browser/intents/device_attached_intent_source.cc (right): http://codereview.chromium.org/10868110/diff/2002/chrome/browser/intents/device_attached_intent_source.cc#newcode134 chrome/browser/intents/device_attached_intent_source.cc:134: // TODO(kinuko, kmadhusu): Use a different file system ...
8 years, 3 months ago (2012-08-27 20:30:52 UTC) #2
kmadhusu
https://chromiumcodereview.appspot.com/10868110/diff/2002/chrome/browser/intents/device_attached_intent_source.cc File chrome/browser/intents/device_attached_intent_source.cc (right): https://chromiumcodereview.appspot.com/10868110/diff/2002/chrome/browser/intents/device_attached_intent_source.cc#newcode134 chrome/browser/intents/device_attached_intent_source.cc:134: // TODO(kinuko, kmadhusu): Use a different file system type ...
8 years, 3 months ago (2012-08-27 20:44:56 UTC) #3
kmadhusu
gbillock@: Could you do the OWNER review? Thanks.
8 years, 3 months ago (2012-08-27 20:45:18 UTC) #4
groby-ooo-7-16
Unless you need more than an OWNERS rubber stamp, LGTM
8 years, 3 months ago (2012-08-27 20:47:43 UTC) #5
kmadhusu
groby@: Thanks for doing the OWNER's check.
8 years, 3 months ago (2012-08-27 20:50:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/10868110/8001
8 years, 3 months ago (2012-08-27 20:50:57 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-08-27 23:16:27 UTC) #8
Change committed as 153573

Powered by Google App Engine
This is Rietveld 408576698