Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 10868109: Factored out code, based on Florian's recent submit. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_optimizer.cc
===================================================================
--- runtime/vm/flow_graph_optimizer.cc (revision 11390)
+++ runtime/vm/flow_graph_optimizer.cc (working copy)
@@ -607,11 +607,8 @@
// TODO(srdjan): Add check class comp for mixed smi/non-smi.
if (HasOneTarget(unary_checks) &&
(unary_checks.GetReceiverClassIdAt(0) != kSmiCid)) {
- Value* value = comp->ArgumentAt(0)->value()->CopyValue();
// Type propagation has not run yet, we cannot eliminate the check.
- CheckClassComp* check = new CheckClassComp(value, comp);
- check->set_ic_data(&unary_checks);
- InsertBefore(instr, check, instr->env(), BindInstr::kUnused);
+ AddCheckClass(instr, comp, comp->ArgumentAt(0)->value()->CopyValue());
// Call can still deoptimize, do not detach environment from instr.
call_with_checks = false;
} else {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698