Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 10868101: Merge 125757 - Prevent showing suggestions when right-clicking a selection range. (Closed)

Created:
8 years, 3 months ago by Hironori Bono
Modified:
8 years, 3 months ago
Reviewers:
Hironori Bono
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1229/
Visibility:
Public.

Description

Merge 125757 - Prevent showing suggestions when right-clicking a selection range. https://bugs.webkit.org/show_bug.cgi?id=94189 Reviewed by Hajime Morita. To emulate Safari, my r120810 changes selection when right-clicking a misspelled word. Unfortunately, this change somehow uses VisibleSelection::isCaretOrRange and it changes the existing selection when right-clicking a selection which includes a misspelled word. This change uses VisibleSelection::isCaret to prevent showing suggestions when right-clicking a selection range. (Neither does Safari show suggestions when there is a selection range.) * src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): TBR=hbono@chromium.org Committed: https://trac.webkit.org/changeset/126725

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M Source/WebKit/chromium/src/ContextMenuClientImpl.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Hironori Bono
8 years, 3 months ago (2012-08-27 06:09:56 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698