Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 10868097: Return error only if local printer is missing and default caps othervise. (Closed)

Created:
8 years, 4 months ago by Vitaly Buka (NO REVIEWS)
Modified:
8 years, 3 months ago
Reviewers:
Robert Toscano, gene
CC:
chromium-reviews
Visibility:
Public.

Description

Returns error only if local printer is missing and default caps otherwise. Allows color switch in preview for printers if caps unavailable. BUG=144056 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153538

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -20 lines) Patch
M chrome/browser/printing/print_system_task_proxy.cc View 1 1 chunk +25 lines, -20 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Vitaly Buka (NO REVIEWS)
8 years, 4 months ago (2012-08-26 06:06:36 UTC) #1
Vitaly Buka (NO REVIEWS)
On 2012/08/26 06:06:36, Vitaly Buka wrote: new patch
8 years, 3 months ago (2012-08-27 18:53:43 UTC) #2
Robert Toscano
LGTM
8 years, 3 months ago (2012-08-27 19:08:08 UTC) #3
gene1
lgtm
8 years, 3 months ago (2012-08-27 19:08:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10868097/7001
8 years, 3 months ago (2012-08-27 19:10:44 UTC) #5
commit-bot: I haz the power
Presubmit check for 10868097-7001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-08-27 19:10:46 UTC) #6
gene
lgtm now from chromium account :)
8 years, 3 months ago (2012-08-27 19:13:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10868097/7001
8 years, 3 months ago (2012-08-27 19:14:15 UTC) #8
commit-bot: I haz the power
8 years, 3 months ago (2012-08-27 20:58:04 UTC) #9
Change committed as 153538

Powered by Google App Engine
This is Rietveld 408576698