Throw a runtime error when trying to call a constructor of a class that could not be resolved.

lib/compiler/implementation/ssa/builder.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class Interceptors {
   Compiler compiler;
   Interceptors(Compiler this.compiler);
 
   SourceString mapOperatorToMethodName(Operator op) {
     String name = op.source.stringValue;
@@ skipping 83 matching lines @@
   }
 
   Element getIndexAssignmentInterceptor() {
     return compiler.findHelper(const SourceString('indexSet'));
   }
 
   Element getExceptionUnwrapper() {
     return compiler.findHelper(const SourceString('unwrapException'));
   }
 
+  Element getThrowRuntimeError() {
+    return compiler.findHelper(const SourceString('throwRuntimeError'));
+  }
+
   Element getClosureConverter() {
     return compiler.findHelper(const SourceString('convertDartClosureToJS'));
   }
 
   Element getTraceFromException() {
     return compiler.findHelper(const SourceString('getTraceFromException'));
   }
 
   Element getEqualsInterceptor() {
     return compiler.findHelper(const SourceString('eq'));
@@ skipping 2183 matching lines @@
       push(new HInvokeSuper(inputs));
     } else {
       target = new HInvokeSuper(inputs);
       add(target);
       inputs = <HInstruction>[target];
       addDynamicSendArgumentsToList(node, inputs);
       push(new HInvokeClosure(selector, inputs));
     }
   }
 
-  visitNewSend(Send node) {
+  visitNewSend(Send node, Element constructor) {

[ngeoffray, 2012/08/24 15:43:48]

I'd rather not have this new parameter. The send and the element must be
connected when entering that method, and I prefer that we just fetch the element
out of the node.

[karlklose, 2012/08/28 09:09:15]

Done.

     computeType(element) {
       Element originalElement = elements[node];
       if (originalElement.getEnclosingClass() === compiler.listClass) {
         if (node.arguments.isEmpty()) {
           return HType.EXTENDABLE_ARRAY;
         } else {
           return HType.MUTABLE_ARRAY;
         }
       } else if (element.isGenerativeConstructor()) {
         ClassElement cls = element.getEnclosingClass();
         return new HBoundedType.exact(cls.type);
       } else {
         return HType.UNKNOWN;
       }
     }
 
     Selector selector = elements.getSelector(node);
-    Element element = elements[node];
-    if (compiler.enqueuer.resolution.getCachedElements(element) === null) {
-      compiler.internalError("Unresolved element: $element", node: node);
+    if (compiler.enqueuer.resolution.getCachedElements(constructor) === null) {
+      compiler.internalError("Unresolved element: $constructor", node: node);
     }
-    FunctionElement functionElement = element;
-    element = functionElement.defaultImplementation;
-    HInstruction target = new HStatic(element);
+    FunctionElement functionElement = constructor;
+    constructor = functionElement.defaultImplementation;
+    HInstruction target = new HStatic(constructor);
     add(target);
     var inputs = <HInstruction>[];
     inputs.add(target);
     bool succeeded = addStaticSendArgumentsToList(selector, node.arguments,
-                                                  element, inputs);
+                                                  constructor, inputs);
     if (!succeeded) {
       // TODO(ngeoffray): Match the VM behavior and throw an
       // exception at runtime.
       compiler.cancel('Unimplemented non-matching static call', node: node);
     }
 
-    HType elementType = computeType(element);
+    HType elementType = computeType(constructor);
     HInstruction newInstance = new HInvokeStatic(inputs, elementType);
     pushWithPosition(newInstance, node);
 
     TypeAnnotation annotation = getTypeAnnotationFromSend(node);
     Type type = elements.getType(annotation);
     generateSetRuntimeTypeInformation(newInstance, type);
   }
 
   generateSetRuntimeTypeInformation(HInstruction instance, Type type) {
     if (compiler.codegenWorld.rti.hasTypeArguments(type)) {
@@ skipping 63 matching lines @@
     } else if (send.selector is Send) {
       Send selector = send.selector;
       if (selector.receiver is TypeAnnotation) {
         return selector.receiver;
       }
     } else {
       compiler.internalError("malformed send in new expression");
     }
   }
 
+  void generateRuntimeError(Node node, String message) {
+    final messageObject = new DartString.literal(message.toString());

[ngeoffray, 2012/08/24 15:43:48]

final -> DartString (for consistency)

[ngeoffray, 2012/08/24 15:43:48]

message is already a String.

[karlklose, 2012/08/28 09:09:15]

Done.

[karlklose, 2012/08/28 09:09:15]

Done.

+    HInstruction errorMessage = graph.addConstantString(messageObject, node);
+    Element helper = interceptors.getThrowRuntimeError();
+    pushInvokeHelper1(helper, errorMessage);
+  }
+
   visitNewExpression(NewExpression node) {
     Element element = elements[node.send];
     if (Element.isInvalid(element)) {
       ErroneousElement error = element;
       Message message = error.errorMessage;
       if (message.kind === MessageKind.CANNOT_FIND_CONSTRUCTOR) {
         Element helper =
             compiler.findHelper(const SourceString('throwNoSuchMethod'));
         DartString receiverLiteral = new DartString.literal('');
         HInstruction receiver = graph.addConstantString(receiverLiteral, node);
         String constructorName = 'constructor ${message.arguments[0]}';
         DartString nameLiteral = new DartString.literal(constructorName);
         HInstruction name = graph.addConstantString(nameLiteral, node.send);
         List<HInstruction> inputs = <HInstruction>[];
         node.send.arguments.forEach((argumentNode) {
           visit(argumentNode);
           HInstruction value = pop();
           inputs.add(value);
         });
         HInstruction arguments = new HLiteralList(inputs);
         add(arguments);
         pushInvokeHelper3(helper, receiver, name, arguments);
+      } else if (message.kind === MessageKind.CANNOT_RESOLVE) {
+        generateRuntimeError(node.send, message.message);
       } else {
         compiler.cancel('Unimplemented unresolved constructor call',

[ngeoffray, 2012/08/24 15:43:48]

Can this still happen?

[karlklose, 2012/08/28 09:09:15]

It should not. I changed it to an internal error saying 'unexpected ...'.

                         node: node);
       }
     } else if (node.isConst()) {
       // TODO(karlklose): add type representation
       ConstantHandler handler = compiler.constantHandler;
       Constant constant = handler.compileNodeWithDefinitions(node, elements);
       stack.add(graph.addConstant(constant));
     } else {
-      visitNewSend(node.send);
+      visitNewSend(node.send, element);
     }
   }
 
   visitSendSet(SendSet node) {
     Operator op = node.assignmentOperator;
     if (node.isSuperCall) {
       Element element = elements[node];
       if (element === null) return generateSuperNoSuchMethodSend(node);
       HInstruction target = new HStatic(element);
       HInstruction context = localsHandler.readThis();
@@ skipping 1204 matching lines @@
           new HSubGraphBlockInformation(elseBranch.graph));
 
     HBasicBlock conditionStartBlock = conditionBranch.block;
     conditionStartBlock.setBlockFlow(info, joinBlock);
     SubGraph conditionGraph = conditionBranch.graph;
     HIf branch = conditionGraph.end.last;
     assert(branch is HIf);
     branch.blockInformation = conditionStartBlock.blockFlow;
   }
 }