chrome/test/data/extensions/unpacker/bad_path/manifest.json - Issue 10868050: Remove "theme" in extension/app unpacker error messages, make those messages localizable, and add u…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/unpacker/bad_path/manifest.json

Issue 10868050: Remove "theme" in extension/app unpacker error messages, make those messages localizable, and add u… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Applied suggestions in patch set 2 comments and added paths in errors. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/common/extensions/unpacker_unittest.cc ('K') | « chrome/test/data/extensions/unpacker/bad_path/bad_path.sh ('k') | chrome/test/data/extensions/unpacker/bad_path/product_logo_128.png » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 {

	2 "name": "Bad Path",

	3 "version": "1.0",

	4 "description": "Package with an invalid path to be used for unit testing. The path below is carefully chosen so: 1) it contains '..'; and 2) it resolves to a valid file at package installation time so no invalid-image-error is raised befo re the invalid-image-path-error one is. Because of the invalid path, this packag e needs to be packaged with bad_path.sh rather than Chromium.",

	5 "theme": {"images" : {"bad_path" : "../CRX_INSTALL/product_logo_128.png"}}

	6 }

OLD	NEW