Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: chrome/common/extensions/unpacker.h

Issue 10868050: Remove "theme" in extension/app unpacker error messages, make those messages localizable, and add u… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Uploading latest changes after fiddling with git to make sure all changes are included in the CL. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/common/extensions/unpacker.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_EXTENSIONS_UNPACKER_H_ 5 #ifndef CHROME_COMMON_EXTENSIONS_UNPACKER_H_
6 #define CHROME_COMMON_EXTENSIONS_UNPACKER_H_ 6 #define CHROME_COMMON_EXTENSIONS_UNPACKER_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 // Decodes the image at the given path and puts it in our list of decoded 79 // Decodes the image at the given path and puts it in our list of decoded
80 // images. 80 // images.
81 bool AddDecodedImage(const FilePath& path); 81 bool AddDecodedImage(const FilePath& path);
82 82
83 // Parses the catalog at the given path and puts it in our list of parsed 83 // Parses the catalog at the given path and puts it in our list of parsed
84 // catalogs. 84 // catalogs.
85 bool ReadMessageCatalog(const FilePath& message_path); 85 bool ReadMessageCatalog(const FilePath& message_path);
86 86
87 // Set the error message. 87 // Set the error message.
88 void SetError(const std::string& error); 88 void SetError(const std::string& error);
89 void SetUTF16Error(const string16& error);
89 90
90 // The extension to unpack. 91 // The extension to unpack.
91 FilePath extension_path_; 92 FilePath extension_path_;
92 93
93 // The extension ID if known. 94 // The extension ID if known.
94 std::string extension_id_; 95 std::string extension_id_;
95 96
96 // The location to use for the created extension. 97 // The location to use for the created extension.
97 Extension::Location location_; 98 Extension::Location location_;
98 99
(...skipping 16 matching lines...) Expand all
115 116
116 // The last error message that was set. Empty if there were no errors. 117 // The last error message that was set. Empty if there were no errors.
117 string16 error_message_; 118 string16 error_message_;
118 119
119 DISALLOW_COPY_AND_ASSIGN(Unpacker); 120 DISALLOW_COPY_AND_ASSIGN(Unpacker);
120 }; 121 };
121 122
122 } // namespace extensions 123 } // namespace extensions
123 124
124 #endif // CHROME_COMMON_EXTENSIONS_UNPACKER_H_ 125 #endif // CHROME_COMMON_EXTENSIONS_UNPACKER_H_
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/common/extensions/unpacker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698