Promote BookmarkService to a public API.

Promote BookmarkService to a public API.

R=joi,sky
BUG=144050
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154000

[Jói, 2012-08-23 09:23:30]

LGTM

[erikwright (departed), 2012-08-23 18:30:55]

sky, PTAL.

[sky, 2012-08-23 19:49:43]

This is the first I've heard of chrome/browser/api. What is it intended for?

[erikwright (departed), 2012-08-23 21:11:44]

chrome/browser/api will define APIs between browser components and browser.

In general these APIs will consist of pure-virtual interfaces with a few
exceptions such as POD classes, utility classes that are not tied to a
component implementation.

As part of browser componentization we will start by moving existing API
definitions into the api/ directory, eventually defining new APIs where
necessary. Over time we will eliminate the compile-time dependencies
between components, and eventually the link-time dependencies as well.

Hence the DEPS file CL that you have seen where we create 'aspirational'
rules followed by a list of grandfathered exceptions. We hope to gradually
reduce those exceptions to 0.

On Thu, Aug 23, 2012 at 12:49 PM, <sky@chromium.org> wrote:

> This is the first I've heard of chrome/browser/api. What is it intended
> for?
>
>
http://codereview.chromium.**org/10868039/<http://codereview.chromium.org/108...
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "browser-components-watch" group.
> To post to this group, send email to browser-components-watch@**
> chromium.org <browser-components-watch@chromium.org>.
> To unsubscribe from this group, send email to browser-components-watch+**
> unsubscribe@chromium.org<browser-components-watch%2Bunsubscribe@chromium.org>
> .
> For more options, visit https://groups.google.com/a/**
>
chromium.org/groups/opt_out<https://groups.google.com/a/chromium.org/groups/opt_out>
> .
>
>
>

[Jói, 2012-08-23 21:25:03]

For background, see
http://www.chromium.org/developers/design-documents/browser-components
and the comments at the top of chrome/browser/api/DEPS.

Cheers,
Jói


On Thu, Aug 23, 2012 at 9:11 PM, Erik Wright <erikwright@chromium.org> wrote:
> chrome/browser/api will define APIs between browser components and browser.
>
> In general these APIs will consist of pure-virtual interfaces with a few
> exceptions such as POD classes, utility classes that are not tied to a
> component implementation.
>
> As part of browser componentization we will start by moving existing API
> definitions into the api/ directory, eventually defining new APIs where
> necessary. Over time we will eliminate the compile-time dependencies between
> components, and eventually the link-time dependencies as well.
>
> Hence the DEPS file CL that you have seen where we create 'aspirational'
> rules followed by a list of grandfathered exceptions. We hope to gradually
> reduce those exceptions to 0.
>
> On Thu, Aug 23, 2012 at 12:49 PM, <sky@chromium.org> wrote:
>>
>> This is the first I've heard of chrome/browser/api. What is it intended
>> for?
>>
>> http://codereview.chromium.org/10868039/
>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "browser-components-watch" group.
>> To post to this group, send email to
>> browser-components-watch@chromium.org.
>> To unsubscribe from this group, send email to
>> browser-components-watch+unsubscribe@chromium.org.
>> For more options, visit
>> https://groups.google.com/a/chromium.org/groups/opt_out.
>>
>>
>

[sky, 2012-08-24 16:06:45]

LGTM

https://chromiumcodereview.appspot.com/10868039/diff/1013/chrome/browser/hist...
File chrome/browser/history/android/android_provider_backend_unittest.cc
(right):

https://chromiumcodereview.appspot.com/10868039/diff/1013/chrome/browser/hist...
chrome/browser/history/android/android_provider_backend_unittest.cc:17: #include
"chrome/browser/api/bookmarks/bookmark_service.h"
sort

https://chromiumcodereview.appspot.com/10868039/diff/1013/chrome/browser/hist...
File chrome/browser/history/android/bookmark_model_sql_handler.cc (right):

https://chromiumcodereview.appspot.com/10868039/diff/1013/chrome/browser/hist...
chrome/browser/history/android/bookmark_model_sql_handler.cc:10: #include
"chrome/browser/api/bookmarks/bookmark_service.h"
sort

https://chromiumcodereview.appspot.com/10868039/diff/1013/chrome/browser/hist...
File chrome/browser/history/history_backend.cc (right):

https://chromiumcodereview.appspot.com/10868039/diff/1013/chrome/browser/hist...
chrome/browser/history/history_backend.cc:23: #include
"chrome/browser/api/bookmarks/bookmark_service.h"
sort

[commit-bot: I haz the power, 2012-08-29 03:15:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erikwright@chromium.org/10868039/9001

[commit-bot: I haz the power, 2012-08-29 03:15:40]

Can't process patch for file chrome/browser/api/OWNERS.
Hunk header is incorrect: 1 vs 2

[commit-bot: I haz the power, 2012-08-29 03:21:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erikwright@chromium.org/10868039/12001

[commit-bot: I haz the power, 2012-08-29 03:21:58]

Can't process patch for file chrome/browser/api/OWNERS.
Hunk header is incorrect: 1 vs 2

[commit-bot: I haz the power, 2012-08-29 18:48:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erikwright@chromium.org/10868039/12001

[commit-bot: I haz the power, 2012-08-29 22:09:59]

Try job failure for 10868039-12001 (retry) on win_rel for steps
"interactive_ui_tests, browser_tests".
It's a second try, previously, steps "interactive_ui_tests, browser_tests"
failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...