Split AudioRendererMixer::VectorFMAC into VectorMath library.

Split AudioRendererMixer::VectorFMAC into VectorMath library.

Prepare the future home for more optimized vector math routines,
specifically FMUL for volume adjustment.

Additionally the FMAC operation will be used for browser side
mixing as well as channel upmixing and downmixing.

BUG=none
TEST=unittests.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153122

[DaleCurtis, 2012-08-23 02:00:14]

No real code changes, just code movement, renaming, and test cleanup.

[Ami GONE FROM CHROMIUM, 2012-08-23 17:28:12]

LGTM % nit & wondering what "test cleanup" means in the CL description.

https://chromiumcodereview.appspot.com/10868037/diff/1/media/base/vector_math.cc
File media/base/vector_math.cc (right):

https://chromiumcodereview.appspot.com/10868037/diff/1/media/base/vector_math...
media/base/vector_math.cc:43: DCHECK_EQ(0u, reinterpret_cast<uintptr_t>(dest) &
0x0F);
Do these checks belong in FMAC() instead of here?

https://chromiumcodereview.appspot.com/10868037/diff/1/media/base/vector_math.h
File media/base/vector_math.h (right):

https://chromiumcodereview.appspot.com/10868037/diff/1/media/base/vector_math...
media/base/vector_math.h:27: static void FMAC_SSE(const float src[], float
scale, int len, float dest[]);
As long as this class is a container of stateless static functions, make its
ctor/dtor private?

(could also make it a namespace, e.g. with a vector_math_testing.h header to
expose the _C/_SSE signatures for testing)

[DaleCurtis, 2012-08-23 19:59:54]

By unittest cleanup I meant the refactoring of various allocations and
manipulations used by the tests into the VectorMathTest class.

https://chromiumcodereview.appspot.com/10868037/diff/1/media/base/vector_math.cc
File media/base/vector_math.cc (right):

https://chromiumcodereview.appspot.com/10868037/diff/1/media/base/vector_math...
media/base/vector_math.cc:43: DCHECK_EQ(0u, reinterpret_cast<uintptr_t>(dest) &
0x0F);
On 2012/08/23 17:28:12, Ami Fischman wrote:
> Do these checks belong in FMAC() instead of here?

Technically no, but since CPU selection is done at run time, it's probably safer
to put them there. As a bonus it allows testing without the branding=Chrome
flag. Done.

https://chromiumcodereview.appspot.com/10868037/diff/1/media/base/vector_math.h
File media/base/vector_math.h (right):

https://chromiumcodereview.appspot.com/10868037/diff/1/media/base/vector_math...
media/base/vector_math.h:27: static void FMAC_SSE(const float src[], float
scale, int len, float dest[]);
On 2012/08/23 17:28:12, Ami Fischman wrote:
> As long as this class is a container of stateless static functions, make its
> ctor/dtor private?
> 
> (could also make it a namespace, e.g. with a vector_math_testing.h header to
> expose the _C/_SSE signatures for testing)

Good idea. Using a namespace allows me to get rid of the friend test junk which
will only grow as we add operations here.

[Ami GONE FROM CHROMIUM, 2012-08-23 20:04:36]

LGTM 
nice

https://chromiumcodereview.appspot.com/10868037/diff/8001/media/base/vector_m...
File media/base/vector_math.h (right):

https://chromiumcodereview.appspot.com/10868037/diff/8001/media/base/vector_m...
media/base/vector_math.h:10: namespace vector_math {
should be nested inside namespace media.

[DaleCurtis, 2012-08-23 20:16:42]

Done. Thanks for review!

https://chromiumcodereview.appspot.com/10868037/diff/8001/media/base/vector_m...
File media/base/vector_math.h (right):

https://chromiumcodereview.appspot.com/10868037/diff/8001/media/base/vector_m...
media/base/vector_math.h:10: namespace vector_math {
On 2012/08/23 20:04:37, Ami Fischman wrote:
> should be nested inside namespace media.

Done.

[commit-bot: I haz the power, 2012-08-23 21:35:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/10868037/1014

[commit-bot: I haz the power, 2012-08-24 00:40:48]

Change committed as 153122