Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1526)

Issue 10868034: Fix back-to-back StartPlayback/StopPlayback issue in PPAPI IPC proxy (Closed)

Created:
8 years, 4 months ago by nfullagar
Modified:
8 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Fix back-to-back StartPlayback/StopPlayback issue in PPAPI IPC proxy where subsequent StartPlayback on the same audio device was not triggering audio callbacks. BUG=144037 TEST=updated test included Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153359

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -4 lines) Patch
M ppapi/shared_impl/ppb_audio_shared.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M ppapi/tests/test_audio.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/tests/test_audio.cc View 1 2 3 4 2 chunks +69 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nfullagar
8 years, 4 months ago (2012-08-24 20:43:06 UTC) #1
brettw
Thanks for the nice test. LGTM
8 years, 4 months ago (2012-08-24 20:59:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nfullagar@google.com/10868034/4008
8 years, 4 months ago (2012-08-24 21:56:24 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-25 00:22:54 UTC) #4
Change committed as 153359

Powered by Google App Engine
This is Rietveld 408576698