Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 10868032: Fix DoDeferredNumberTagU to keep the value in xmm1 instead of xmm0 on x64. (Closed)

Created:
8 years, 4 months ago by Vyacheslav Egorov (Google)
Modified:
8 years, 4 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Fix DoDeferredNumberTagU to keep the value in xmm1 instead of xmm0 on x64. xmm0 is not saved across runtime call on x64 because MacroAssembler::EnterExitFrameEpilogue preserves only allocatable XMM registers unlike on ia32 where it preserves all registers. Cleanup handling of shifts: SHR can deoptimize only when its a shift by 0, all other shift never deoptimize. Fix type inference for i-to-t change instruction. On X64 this ensures that write-barrier is generated correctly. R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12373

Patch Set 1 #

Patch Set 2 : Cleanup handling of shifts #

Patch Set 3 : Fix inferred type for i-to-t change on x64 #

Patch Set 4 : expose gc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -27 lines) Patch
M src/arm/lithium-arm.cc View 1 1 chunk +6 lines, -8 lines 0 comments Download
M src/hydrogen.cc View 1 1 chunk +10 lines, -1 line 0 comments Download
M src/hydrogen-instructions.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 1 chunk +6 lines, -8 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 1 chunk +4 lines, -5 lines 0 comments Download
M test/mjsunit/compiler/uint32.js View 1 2 3 3 chunks +25 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Vyacheslav Egorov (Google)
8 years, 4 months ago (2012-08-22 23:50:00 UTC) #1
Vyacheslav Egorov (Google)
Additionally cleanup handling of shifts: SHR can deoptimize only when its a shift by 0, ...
8 years, 4 months ago (2012-08-23 00:24:15 UTC) #2
Vyacheslav Egorov (Google)
Additionally: Fix type inference for i-to-t change instruction. On X64 this ensures that write-barrier is ...
8 years, 4 months ago (2012-08-23 09:24:04 UTC) #3
danno
8 years, 4 months ago (2012-08-23 15:04:08 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698