Limit the ports used by IT2Me when NAT traversal is disabled.

Limit the ports used by IT2Me when NAT traversal is disabled.

BUG=132785
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153353

[Wez, 2012-08-22 23:45:09]

PTAL

[Sergey Ulanov, 2012-08-22 23:50:33]

http://codereview.chromium.org/10868031/diff/1/remoting/host/plugin/host_scri...
File remoting/host/plugin/host_script_object.cc (right):

http://codereview.chromium.org/10868031/diff/1/remoting/host/plugin/host_scri...
remoting/host/plugin/host_script_object.cc:77: const int kMinPortNumber = 12400;
Maybe put these values somewhere where they can be shared between hosts? E.g. in
remoting/host/network_settings.h?

[Wez, 2012-08-23 23:26:25]

http://codereview.chromium.org/10868031/diff/1/remoting/host/plugin/host_scri...
File remoting/host/plugin/host_script_object.cc (right):

http://codereview.chromium.org/10868031/diff/1/remoting/host/plugin/host_scri...
remoting/host/plugin/host_script_object.cc:77: const int kMinPortNumber = 12400;
On 2012/08/22 23:50:34, sergeyu wrote:
> Maybe put these values somewhere where they can be shared between hosts? E.g.
in
> remoting/host/network_settings.h?

Done.

[Sergey Ulanov, 2012-08-24 18:47:27]

lgtm

https://chromiumcodereview.appspot.com/10868031/diff/5001/remoting/host/netwo...
File remoting/host/network_settings.h (right):

https://chromiumcodereview.appspot.com/10868031/diff/5001/remoting/host/netwo...
remoting/host/network_settings.h:12: static const int kDefaultMinPort = 12400;
Please add comments to explain how these constants are used.

[Wez, 2012-08-24 19:51:24]

https://chromiumcodereview.appspot.com/10868031/diff/5001/remoting/host/netwo...
File remoting/host/network_settings.h (right):

https://chromiumcodereview.appspot.com/10868031/diff/5001/remoting/host/netwo...
remoting/host/network_settings.h:12: static const int kDefaultMinPort = 12400;
On 2012/08/24 18:47:27, sergeyu wrote:
> Please add comments to explain how these constants are used.

Done.

[commit-bot: I haz the power, 2012-08-24 19:51:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/10868031/3002

[commit-bot: I haz the power, 2012-08-24 21:28:39]

Try job failure for 10868031-3002 (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, steps "interactive_ui_tests,
content_browsertests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-08-24 21:32:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/10868031/3002

[commit-bot: I haz the power, 2012-08-24 21:34:38]

Try job failure for 10868031-3002 on win_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-08-24 21:39:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/10868031/3002

[commit-bot: I haz the power, 2012-08-24 23:58:59]

Change committed as 153353