Inlining PPAPI_LIBS as its now the same everywhere.

Inlining PPAPI_LIBS as it's now the same everywhere.

We'd like to drop PPAPI_LIBS nacl side, so inlining.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=2957
TEST=None
R=mseaborn@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152940

[Mark Seaborn, 2012-08-22 21:04:32]

LGTM with the fix below.  However I doubt cleaning up this deprecated code is
worth our while.  It would be better to spend effort on replacing and removing
it.

http://codereview.chromium.org/10868029/diff/1/ppapi/native_client/tests/eart...
File ppapi/native_client/tests/earth/nacl.scons (left):

http://codereview.chromium.org/10868029/diff/1/ppapi/native_client/tests/eart...
ppapi/native_client/tests/earth/nacl.scons:34: 'ppapi_cpp',
You dropped ppapi_cpp.  Did you mean to drop ppapi (which requires waiting for a
DEPS update to get your library_deps.py change)?

BTW, your library_deps.py change is fine while PPAPI-related stuff remains on
the NaCl side, but eventually we want to drop PPAPI-related stuff from the NaCl
side...  So I'd leave both "ppapi" and "ppapi_cpp" in here.

[bradn, 2012-08-22 21:09:17]

Agreed generally we don't want to be mucking with this stuff.

http://codereview.chromium.org/10868029/diff/1/ppapi/native_client/tests/eart...
File ppapi/native_client/tests/earth/nacl.scons (left):

http://codereview.chromium.org/10868029/diff/1/ppapi/native_client/tests/eart...
ppapi/native_client/tests/earth/nacl.scons:34: 'ppapi_cpp',
On 2012/08/22 21:04:32, Mark Seaborn wrote:
> You dropped ppapi_cpp.  Did you mean to drop ppapi (which requires waiting for
a
> DEPS update to get your library_deps.py change)?
> 
> BTW, your library_deps.py change is fine while PPAPI-related stuff remains on
> the NaCl side, but eventually we want to drop PPAPI-related stuff from the
NaCl
> side...  So I'd leave both "ppapi" and "ppapi_cpp" in here.

Yes, this was a textual error.
Amusingly this one isn't even hooked into the build, so nothing broke.

[commit-bot: I haz the power, 2012-08-22 21:11:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bradnelson@google.com/10868029/5001

[commit-bot: I haz the power, 2012-08-22 23:55:35]

Failed to apply patch for
ppapi/native_client/tests/ppapi_browser/ppb_pdf/nacl.scons:
While running patch -p1 --forward --force;
patching file ppapi/native_client/tests/ppapi_browser/ppb_pdf/nacl.scons
Hunk #1 FAILED at 17.
1 out of 1 hunk FAILED -- saving rejects to file
ppapi/native_client/tests/ppapi_browser/ppb_pdf/nacl.scons.rej

[commit-bot: I haz the power, 2012-08-23 00:58:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bradnelson@google.com/10868029/37

[commit-bot: I haz the power, 2012-08-23 03:27:56]

Change committed as 152940