Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: chrome_frame/test/test_with_web_server.h

Issue 10868027: Attempt to fix flake in FullTabModeIE_TestPostReissue by avoiding loopback address. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome_frame/test/test_with_web_server.h
diff --git a/chrome_frame/test/test_with_web_server.h b/chrome_frame/test/test_with_web_server.h
index 4c7422048eeaaf178660d6cac562403ced0c9de2..826cae7381116ba231e3b209ad87997f481e56d2 100644
--- a/chrome_frame/test/test_with_web_server.h
+++ b/chrome_frame/test/test_with_web_server.h
@@ -242,6 +242,7 @@ class ChromeFrameTestWithWebServer : public testing::Test {
// The web server from which we serve the web!
static chrome_frame_test::TimedMsgLoop* loop_;
+ static std::string local_address_;
static testing::StrictMock<MockWebServerListener>* listener_mock_;
static testing::StrictMock<MockWebServer>* server_mock_;
@@ -253,7 +254,8 @@ class ChromeFrameTestWithWebServer : public testing::Test {
// SimpleWebServer class.
class SimpleWebServerTest {
public:
- explicit SimpleWebServerTest(int port) : server_(port), port_(port) {
+ SimpleWebServerTest(const std::string& address, int port)
+ : server_(address, port), port_(port) {
}
~SimpleWebServerTest() {
@@ -271,8 +273,8 @@ class SimpleWebServerTest {
}
std::wstring FormatHttpPath(const wchar_t* document_path) {
- return base::StringPrintf(L"http://localhost:%i/%ls", port_,
- document_path);
+ return base::StringPrintf(L"http://%hs:%i/%ls", server_.host().c_str(),
+ port_, document_path);
}
// Returns the last client request object.

Powered by Google App Engine
This is Rietveld 408576698