Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 10868027: Attempt to fix flake in FullTabModeIE_TestPostReissue by avoiding loopback address. (Closed)

Created:
8 years, 4 months ago by grt (UTC plus 2)
Modified:
8 years, 4 months ago
Reviewers:
robertshield
CC:
chromium-reviews, grt+watch_chromium.org, amit, robertshield
Visibility:
Public.

Description

Attempt to fix flake in FullTabModeIE_TestPostReissue by avoiding loopback address. This change makes all remaining tests in the suite use an address on a NIC rather than the loopback address. I don't know whether it'll resolve the flake or not. BUG=143699 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153362

Patch Set 1 #

Total comments: 2

Patch Set 2 : better logging and better format strings #

Patch Set 3 : fixup net tests #

Patch Set 4 : another try with net tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -33 lines) Patch
M chrome_frame/test/mock_ie_event_sink_test.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome_frame/test/net/fake_external_tab.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M chrome_frame/test/test_server.h View 5 chunks +15 lines, -3 lines 0 comments Download
M chrome_frame/test/test_server.cc View 1 3 chunks +16 lines, -5 lines 0 comments Download
M chrome_frame/test/test_server_test.cc View 1 4 chunks +21 lines, -8 lines 0 comments Download
M chrome_frame/test/test_with_web_server.h View 1 3 chunks +5 lines, -2 lines 0 comments Download
M chrome_frame/test/test_with_web_server.cc View 7 chunks +8 lines, -5 lines 0 comments Download
M chrome_frame/test/url_request_test.cc View 1 6 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
grt (UTC plus 2)
8 years, 4 months ago (2012-08-22 19:50:25 UTC) #1
robertshield
Awesome, thanks. Hope this works. LGTM https://chromiumcodereview.appspot.com/10868027/diff/1/chrome_frame/test/test_server.cc File chrome_frame/test/test_server.cc (right): https://chromiumcodereview.appspot.com/10868027/diff/1/chrome_frame/test/test_server.cc#newcode160 chrome_frame/test/test_server.cc:160: DCHECK(server_.get() != NULL); ...
8 years, 4 months ago (2012-08-22 20:18:27 UTC) #2
grt (UTC plus 2)
Thanks. Committing now. The win and win_cf test failures are http://crbug.com/144649, which is unrelated to ...
8 years, 4 months ago (2012-08-24 15:36:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/10868027/10002
8 years, 4 months ago (2012-08-24 15:36:48 UTC) #4
commit-bot: I haz the power
Try job failure for 10868027-10002 (retry) (retry) on linux_chromeos for step "browser_tests". It's a second ...
8 years, 4 months ago (2012-08-24 21:19:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/10868027/10002
8 years, 4 months ago (2012-08-24 22:20:28 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-25 00:39:43 UTC) #7
Change committed as 153362

Powered by Google App Engine
This is Rietveld 408576698