lib/html/src/DocumentFragmentWrappingImplementation.dart - Issue 10868026: Adding .toggle method to Element.classes to match the JS element.classList.toggle method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/html/src/DocumentFragmentWrappingImplementation.dart

Issue 10868026: Adding .toggle method to Element.classes to match the JS element.classList.toggle method. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Incorporating review feedback. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/html/src/DocumentFragmentWrappingImplementation.dart

diff --git a/lib/html/src/DocumentFragmentWrappingImplementation.dart b/lib/html/src/DocumentFragmentWrappingImplementation.dart

index a863dee1dbacb5a9ad04e92fecdf0aff03006656..6fd883b40c559058002c3cda2cc760b78d90d3b4 100644

--- a/lib/html/src/DocumentFragmentWrappingImplementation.dart

+++ b/lib/html/src/DocumentFragmentWrappingImplementation.dart

@@ -288,8 +288,7 @@ class DocumentFragmentWrappingImplementation extends NodeWrappingImplementation

Element get offsetParent() => null;

Element get parent() => null;

Map<String, String> get attributes() => const {};

- // Issue 174: this should be a const set.

- Set<String> get classes() => new Set<String>();

+ CSSClassSet get classes() => null;

Map<String, String> get dataAttributes() => const {};

CSSStyleDeclaration get style() => new EmptyStyleDeclaration();

Future<CSSStyleDeclaration> get computedStyle() =>

« no previous file with comments | « lib/html/dartium/html_dartium.dart ('k') | lib/html/src/SVGElementWrappingImplementation.dart » ('j') | no next file with comments »