Browser Plugin: New Implementation (Browser Side)

content/browser/browser_plugin/browser_plugin_guest_helper.h

Index: content/browser/browser_plugin/browser_plugin_guest_helper.h
diff --git a/content/browser/browser_plugin/browser_plugin_guest_helper.h b/content/browser/browser_plugin/browser_plugin_guest_helper.h
new file mode 100644
index 0000000000000000000000000000000000000000..7f1a643ff593d5251470d80c436de7fc32626421
--- /dev/null
+++ b/content/browser/browser_plugin/browser_plugin_guest_helper.h
@@ -0,0 +1,71 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_BROWSER_PLUGIN_BROWSER_PLUGIN_GUEST_HELPER_H_
+#define CONTENT_BROWSER_BROWSER_PLUGIN_BROWSER_PLUGIN_GUEST_HELPER_H_
+
+#include <string>

[jam, 2012/09/17 17:47:53]

nit: skip including <string> since this is very basic that's included by many of
your headers already (i.e. this is like not including basictypes.h)

[lazyboy, 2012/09/17 20:22:24]

Removed them all wherever I could, but cannot move this one now since the other
includes are not pulling it in amy more.
Done.

+
+#include "base/compiler_specific.h"
+#include "content/browser/browser_plugin/browser_plugin_guest.h"
+#include "content/public/browser/render_view_host_observer.h"
+#include "content/public/browser/notification_observer.h"
+#include "content/public/browser/web_contents_observer.h"

[jam, 2012/09/17 17:47:53]

not needed

[lazyboy, 2012/09/17 20:22:24]

Done.

+#include "content/public/browser/notification_registrar.h"
+#include "ipc/ipc_channel_handle.h"
+#include "ipc/ipc_sync_message.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/WebInputEvent.h"
+#include "ui/surface/transport_dib.h"
+#include "webkit/glue/webcursor.h"

[jam, 2012/09/17 17:47:53]

do you really need to include this instead of forward declaring?

also you don't need all these includes

[lazyboy, 2012/09/17 20:22:24]

Done.

+
+namespace gfx {
+class Size;
+}
+
+struct BrowserPluginHostMsg_ResizeGuest_Params;
+struct ViewHostMsg_UpdateRect_Params;
+
+namespace content {
+
+class RenderViewHost;
+
+// Helper for browser plugin guest.
+//
+// It overrides different WebContents messages that require special treatment
+// for a WebContents to act as a guest. All functionality is handled by its
+// delegate. This class exists so we have separation of messages requiring
+// special handling, which can be moved to a message filter (IPC thread) for
+// future optimization.
+//
+// The lifetime of this class is managed by the associated RenderViewHost. A
+// BrowserPluginGuestHelper is created whenever a BrowserPluginGuest is created.
+class BrowserPluginGuestHelper : public RenderViewHostObserver {
+ public:
+  BrowserPluginGuestHelper(BrowserPluginGuest* guest,
+                           RenderViewHost* render_view_host);
+  virtual ~BrowserPluginGuestHelper();
+
+ protected:
+  // RenderViewHostObserver implementation.
+  virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
+
+ private:
+  // Message handlers
+  void OnUpdateRect(const ViewHostMsg_UpdateRect_Params& params);
+  void OnHandleInputEventAck(WebKit::WebInputEvent::Type event_type,
+                             bool processed);
+  void OnTakeFocus(bool reverse);
+  void OnShowWidget(int route_id, const gfx::Rect& initial_pos);
+  void OnSetCursor(const WebCursor& cursor);
+
+  BrowserPluginGuest* guest_;
+  // A scoped container for notification registries.
+  NotificationRegistrar registrar_;
+
+  DISALLOW_COPY_AND_ASSIGN(BrowserPluginGuestHelper);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_BROWSER_BROWSER_PLUGIN_BROWSER_PLUGIN_GUEST_HELPER_H_