content/renderer/browser_plugin/browser_plugin.h - Issue 10868012: Browser Plugin: New Implementation (Browser Side)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/browser_plugin/browser_plugin.h

Issue 10868012: Browser Plugin: New Implementation (Browser Side) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master-trial-obrowser

Patch Set: Fix mac build + Address nits from awong@ Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/web_contents/web_contents_impl.cc ('K') | « content/content_tests.gypi ('k') | content/renderer/browser_plugin/browser_plugin.cc » ('j') | content/renderer/browser_plugin/browser_plugin.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/browser_plugin/browser_plugin.h

diff --git a/content/renderer/browser_plugin/browser_plugin.h b/content/renderer/browser_plugin/browser_plugin.h

index 210774b25f4831e1525a63833aedbed87601209c..1709dddeeb2d59511be6cf4af0dfa39e752fcc76 100644

--- a/content/renderer/browser_plugin/browser_plugin.h

+++ b/content/renderer/browser_plugin/browser_plugin.h

@@ -136,7 +136,9 @@ class CONTENT_EXPORT BrowserPlugin :

SkBitmap* sad_guest_;

bool guest_crashed_;

bool resize_pending_;

- long long parent_frame_;

+ // True if we ever sent a NavigateGuest message to the embedder.

awong 2012/09/06 00:23:27 we ever -> we have ever

lazyboy 2012/09/06 04:33:53 Done.

+ bool navigate_src_sent_;

+ int64 parent_frame_;

std::string src_;

typedef std::vector<v8::Persistent<v8::Function> > EventListeners;

typedef std::map<std::string, EventListeners> EventListenerMap;