content/renderer/renderer_main.cc - Issue 10868012: Browser Plugin: New Implementation (Browser Side)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/renderer_main.cc

Issue 10868012: Browser Plugin: New Implementation (Browser Side) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master-trial-obrowser

Patch Set: Rename class as we agreed upon, keep correct type of instances (guest/embedder, not helpers) inside… Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/browser_plugin/browser_plugin.cc ('K') | « content/renderer/browser_plugin/browser_plugin_browsertest.cc ('k') | content/test/data/browser_plugin_infinite_loop.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/renderer_main.cc

diff --git a/content/renderer/renderer_main.cc b/content/renderer/renderer_main.cc

index a84a3cbf813945fedfe3b2657b6c5c089fc9fce8..b95092d4a63fd5160c857bf988a5780a737aae79 100644

--- a/content/renderer/renderer_main.cc

+++ b/content/renderer/renderer_main.cc

@@ -23,6 +23,7 @@

#include "content/public/common/content_switches.h"

#include "content/public/common/main_function_params.h"

#include "content/public/renderer/content_renderer_client.h"

+#include "content/renderer/browser_plugin/browser_plugin_manager_impl.h"

#include "content/renderer/render_process_impl.h"

#include "content/renderer/render_thread_impl.h"

#include "content/renderer/renderer_main_platform_delegate.h"

@@ -213,6 +214,7 @@ int RendererMain(const content::MainFunctionParams& parameters) {

RenderProcessImpl render_process;

new RenderThreadImpl();

#endif

+ new content::BrowserPluginManagerImpl();

Charlie Reis 2012/08/27 20:23:59 Why is this necessary, but wasn't before? Just a

lazyboy 2012/08/28 19:07:14 I believe this is what triggers the renderer side

Fady Samuel 2012/08/29 08:16:20 Yup, there was no BrowserPluginManager instantiate

platform.RunSandboxTests();