Browser Plugin: New Implementation (Browser Side)

content/browser/browser_plugin/browser_plugin_guest.h

Index: content/browser/browser_plugin/browser_plugin_guest.h
diff --git a/content/browser/browser_plugin/browser_plugin_guest.h b/content/browser/browser_plugin/browser_plugin_guest.h
new file mode 100644
index 0000000000000000000000000000000000000000..623cbbdd66c95a5a523e58b9f8bc8d57acccb3f3
--- /dev/null
+++ b/content/browser/browser_plugin/browser_plugin_guest.h
@@ -0,0 +1,125 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_BROWSER_PLUGIN_BROWSER_PLUGIN_GUEST_H_
+#define CONTENT_BROWSER_BROWSER_PLUGIN_BROWSER_PLUGIN_GUEST_H_
+
+#include <string>
+#include <map>
+
+#include "base/compiler_specific.h"
+#include "base/id_map.h"
+#include "content/public/browser/render_view_host_observer.h"
+#include "content/public/browser/web_contents_delegate.h"
+#include "content/public/browser/web_contents_observer.h"
+#include "ipc/ipc_channel_handle.h"
+#include "ipc/ipc_sync_message.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/WebInputEvent.h"
+#include "ui/surface/transport_dib.h"
+#include "ui/gfx/rect.h"
+#include "ui/gfx/size.h"
+#include "webkit/glue/webcursor.h"
+
+namespace gfx {
+class Size;
+}
+
+struct BrowserPluginHostMsg_ResizeGuest_Params;
+struct ViewHostMsg_UpdateRect_Params;
+
+namespace content {
+
+class BrowserPluginEmbedder;
+class RenderProcessHost;
+
+// A browser plugin guest provides functionality for WebContents to operate in
+// the guest role, implements guest specific overrides for ViewHostMsg_*

[Charlie Reis, 2012/08/27 20:23:59]

nit: the guest role and implements

[lazyboy, 2012/08/28 19:07:14]

Done.

+// messages.
+class BrowserPluginGuest : public WebContentsDelegate,
+                           public WebContentsObserver {
+ public:
+  BrowserPluginGuest(int instance_id,
+                     WebContentsImpl* web_contents,
+                     RenderViewHost* render_view_host);
+  virtual ~BrowserPluginGuest();
+
+ private:
+  friend class BrowserPluginEmbedder;
+  friend class BrowserPluginGuestHelper;
+
+  void set_embedder_render_process_host(
+      RenderProcessHost* render_process_host) {
+    embedder_render_process_host_ = render_process_host;
+  }
+  RenderProcessHost* embedder_render_process_host() {
+    return embedder_render_process_host_;
+  }
+  // Returns the identifier that uniquely identifies a browser plugin guest
+  // within an embedder.
+  int instance_id() const { return instance_id_; }
+
+  void SetDamageBuffer(TransportDIB* damage_buffer,
+                       const gfx::Size& size,
+                       float scale_factor);
+  TransportDIB* damage_buffer() const { return damage_buffer_; }
+  const gfx::Size& damage_buffer_size() const { return damage_buffer_size_; }
+  float damage_buffer_scale_factor() const {
+    return damage_buffer_scale_factor_;
+  }
+
+  void UpdateRect(RenderViewHost* render_view_host,
+                  const ViewHostMsg_UpdateRect_Params& params);
+  void UpdateRectACK(int message_id, const gfx::Size& size);
+  // Handles input event routed through the embedder (which is initiated in the
+  // browser plugin {renderer side of the embedder}).

[Charlie Reis, 2012/08/27 20:23:59]

nit: Just used nested parens.

[lazyboy, 2012/08/28 19:07:14]

Done.

+  void HandleInputEvent(RenderViewHost* render_view_host,
+                        const gfx::Rect& guest_rect,
+                        const WebKit::WebInputEvent& event,
+                        IPC::Message* reply_message);
+  // Overrides default ShowWidget message so we show them on the correct
+  // coordinates.
+  void ShowWidget(RenderViewHost* render_view_host,
+                  int route_id,
+                  const gfx::Rect& initial_pos);
+  void SetFocus(bool focused);
+  void SetCursor(const WebCursor& cursor);
+  // Handles input event ack so it's sent to browser plugin host (via embedder)

[Charlie Reis, 2012/08/27 20:23:59]

nit: acks so they're sent

[lazyboy, 2012/08/28 19:07:14]

Done.

+  // instead of default view/widget host.
+  void HandleInputEventAck(RenderViewHost* render_view_host, bool handled);
+
+  void Destroy();
+
+  // WebContentsObserver implementation.
+  // Used to monitor frame navigation to cleanup itself up.

[Charlie Reis, 2012/08/27 20:23:59]

nit: clean

(Why does the guest need cleaning up here?  It doesn't seem to match what the
implementation is doing, so perhaps the comment is stale?)

[lazyboy, 2012/08/28 19:07:14]

Right, cleanup is done on embedder's version of DidCommitProvisional..., removed
comment.

+  virtual void DidCommitProvisionalLoadForFrame(
+      int64 frame_id,
+      bool is_main_frame,
+      const GURL& url,
+      PageTransition transition_type,
+      RenderViewHost* render_view_host) OVERRIDE;
+  virtual void RenderViewGone(base::TerminationStatus status) OVERRIDE;
+
+  // WebContentsDelegate implementation.
+  virtual bool TakeFocus(bool reverse) OVERRIDE;
+  virtual void RendererUnresponsive(WebContents* source) OVERRIDE;
+
+  RenderProcessHost* embedder_render_process_host_;
+  // An identifier that uniquely identifies a browser plugin container within an
+  // embedder.
+  int instance_id_;
+  TransportDIB* damage_buffer_;
+  gfx::Size damage_buffer_size_;
+  float damage_buffer_scale_factor_;
+  scoped_ptr<IPC::Message> pending_input_event_reply_;
+  gfx::Rect guest_rect_;
+  WebCursor cursor_;
+  IDMap<RenderViewHost> pending_updates_;
+  int pending_update_counter_;
+
+  DISALLOW_COPY_AND_ASSIGN(BrowserPluginGuest);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_BROWSER_BROWSER_PLUGIN_BROWSER_PLUGIN_GUEST_H_