content/test/data/browser_plugin_infinite_loop.html - Issue 10868012: Browser Plugin: New Implementation (Browser Side)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/data/browser_plugin_infinite_loop.html

Issue 10868012: Browser Plugin: New Implementation (Browser Side) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master-trial-obrowser

Patch Set: Fix mac build + Address nits from awong@ Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <script type="text/javascript">

	2 function SetSrc(src) {

	3 plugin = document.getElementById('plugin');

	4 plugin.src = src;

	5 }

	6 </script>

	7

	8 <object id="plugin"
	awong 2012/09/06 00:23:27 nit: Indentation of this is strange. Fix? nit: Indentation of this is strange. Fix? lazyboy 2012/09/06 04:33:53 Done. Show quoted text On 2012/09/06 00:23:27, awong wrote: > nit: Indentation of this is strange. Fix? Done.
	9 tabindex="0"

	10 type="application/new-browser-plugin"

	11 width="640"

	12 height="480"

	13 border="0px"></object>

OLD	NEW