Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2884)

Unified Diff: chrome/browser/extensions/extension_icon_image.cc

Issue 10868003: chromeos: Fix pixelated icons in app list and launcher (part 3) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix win compile Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/wm/app_list_controller.cc ('k') | chrome/browser/extensions/image_loading_tracker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_icon_image.cc
diff --git a/chrome/browser/extensions/extension_icon_image.cc b/chrome/browser/extensions/extension_icon_image.cc
index 97c5ead450cd9b2e560695ff18eafa82079c19b4..24125c40a51299bcc185219692b874e725ce1766 100644
--- a/chrome/browser/extensions/extension_icon_image.cc
+++ b/chrome/browser/extensions/extension_icon_image.cc
@@ -78,7 +78,7 @@ class BlankImageSource : public gfx::CanvasImageSource {
namespace extensions {
////////////////////////////////////////////////////////////////////////////////
-// ExtensionIconImage::Source
+// IconImage::Source
class IconImage::Source : public gfx::ImageSkiaSource {
public:
@@ -128,7 +128,7 @@ gfx::ImageSkiaRep IconImage::Source::GetImageForScale(
}
////////////////////////////////////////////////////////////////////////////////
-// ExtensionIconImage
+// IconImage
IconImage::IconImage(
const Extension* extension,
@@ -166,22 +166,26 @@ gfx::ImageSkiaRep IconImage::LoadImageForScaleFactor(
static_cast<int>(resource_size_in_dip_ * scale);
ExtensionResource resource;
- // We try loading bigger image only if resource size is >= 32.
- if (resource_size_in_pixel >= kMatchBiggerTreshold) {
- resource = GetExtensionIconResource(extension_, icon_set_,
- resource_size_in_pixel, ExtensionIconSet::MATCH_BIGGER);
- }
- // If resource is not found by now, try matching smaller one.
- if (resource.empty()) {
- resource = GetExtensionIconResource(extension_, icon_set_,
- resource_size_in_pixel, ExtensionIconSet::MATCH_SMALLER);
+ // Find extension resource for non bundled component extensions.
+ if (!ImageLoadingTracker::IsSpecialBundledExtensionId(extension_->id())) {
+ // We try loading bigger image only if resource size is >= 32.
+ if (resource_size_in_pixel >= kMatchBiggerTreshold) {
+ resource = GetExtensionIconResource(extension_, icon_set_,
+ resource_size_in_pixel, ExtensionIconSet::MATCH_BIGGER);
+ }
+
+ // If resource is not found by now, try matching smaller one.
+ if (resource.empty()) {
+ resource = GetExtensionIconResource(extension_, icon_set_,
+ resource_size_in_pixel, ExtensionIconSet::MATCH_SMALLER);
+ }
+
+ // If there is no resource found, return default icon.
+ if (resource.empty())
+ return default_icon_.GetRepresentation(scale_factor);
}
- // If there is no resource found, return default icon.
- if (resource.empty())
- return default_icon_.GetRepresentation(scale_factor);
-
int id = tracker_.next_id();
load_map_[id].scale_factor = scale_factor;
load_map_[id].is_async = false;
« no previous file with comments | « ash/wm/app_list_controller.cc ('k') | chrome/browser/extensions/image_loading_tracker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698